Ian Jackson <ijack...@chiark.greenend.org.uk> writes:

> So, my discoveries and some other facts:

> The file
>     debian/patches/0008-Add-support-for-Subversion-svnserve.patch
> says
>     diff --git a/conf_convert b/conf_convert
>     new file mode 100755
>     index 0000000..a47ecba

> gbp pq import uses git to apply patches.  git honours the file mode.
> This results in a git tree object containing an executable
> conf_convert.

> dpkg-source does not use git.  It does not honour the file mode (at
> least in the version I have here).  So the source package, when
> unpacked with dpkg-source, produces a non-executable conf_convert.

Aha!  Yes, that explains everything, and now I feel wry about this because
I noticed the same problem in a different context and papered around it
with a chmod in debian/rules and then promptly forgot about it.

I probably should just stuff that file in the debian directory, although
I was vaguely trying to make it usable for upstream (who won't ever take
it, but ah well).  I'll fix it to be consistently broken about the mode
instead.

Thank you for your investigation!

Does this also explain the errors that I got in the initial message that I
opened this bug with, when trying to build the package with gbp?  Those
were odd -- attempts to touch files in non-existent subdirectories of
.git.  I wasn't sure what to make of that.

-- 
Russ Allbery (r...@debian.org)               <http://www.eyrie.org/~eagle/>

Reply via email to