tags 863858 + patch thanks On Wed, Jun 07, 2017 at 04:39:47PM -0600, dann frazier wrote: > I've also added code to reverse the symlink transition. I tested this > in a few ways, all on x86: > > Clean 1:1.6.1-1 install upgrade to 1:1.6.1-2 > - Non-interactive upgrade, cleanup DTRT > 1:16.1-2, modify kdump-tools.cfg, upgrade to 1:1.6.1-2. > - Upgrade correctly prompts for conf-file resolution > Clean 1:1.5.3-2 (stable) install upgrade to 1:1.6.1-2 > - Non-interactive upgrade, no cleanup done > > Let me know what you think.
I tested on ppc64el, and found an issue. On upgrade from a pristine install, dpkg detects that the new file doesn't match the old one. It assumes these are local modifications, and prompts me to resolve it. I've therefore pushed a new branch which moves the ppc64el version of the file on ppc64el instead: https://git.launchpad.net/~dannf/+git/makedumpfile/log/?h=grubcfg3 One heads-up: previously, debian/rules had this code, which I assume was intended to exclude installation of these files on certain archs (x32, arm*, and s390x): ifneq (,$(filter $(DEB_HOST_ARCH),i386 amd64 powerpc ppc64 ppc64el ia64)) install -D -m 644 debian/kdump-tools.grub.default debian/kdump-tools/etc/default/grub.d/kdump-tools.default install -D -m 644 debian/kdump-tools.grub.ppc64el debian/kdump-tools/etc/default/grub.d/kdump-tools..ppc64el endif However, since kdump-tools was Arch: all, it means that those files were installed on all architectures, or on no architectures, depending on what the build *host* was. Since it was presumably always built on x86, all hosts have ended up getting those files. Previously, I was following the (assumed) intent of the existing code by only installing the grub config snippet on the listed architectures. However, given that we provide GRUB packages for arm*, and s390x has a GRUB port, that would have been a regression. Therefore, this latest branch just installs the grub config snippets everywhere. -dann
