On Thu, Jun 01, 2017 at 01:36:06PM +0200, Louis Bouchard wrote:
> Le 01/06/2017 à 06:11, dann frazier a écrit :
> > I wonder if we could simplify this by doing the default config file
> > selection at build time instead of installtime. That should still solve
> > preserve the behavior of dpkg only considering the file to be modified
> > if the user manually edited it.
>
> This is definitively a better solution than a symlink hack. Let's figure
> out how to handle the upgrade & I'll hapilly merge it in.

Ah - and I see I failed to notice the main reason for the symlink
hack in the first place - kdump-tools is arch: all, so build time
decisions weren't an option! Whoops..

That said, I still think I'd rather have a per-arch build of
kdump-tools then install config files for every architecture on every
system. Therefore, I've updated my branch[1] to make kdump-tools
non-Arch: all.

I've also added code to reverse the symlink transition. I tested this
in a few ways, all on x86:

Clean 1:1.6.1-1 install upgrade to 1:1.6.1-2
  - Non-interactive upgrade, cleanup DTRT
1:16.1-2, modify kdump-tools.cfg, upgrade to 1:1.6.1-2.
  - Upgrade correctly prompts for conf-file resolution
Clean 1:1.5.3-2 (stable) install upgrade to 1:1.6.1-2
  - Non-interactive upgrade, no cleanup done

Let me know what you think.

[1] https://git.launchpad.net/~dannf/+git/makedumpfile/log/?h=grubcfg

  -dann

Reply via email to