On Fri, May 5, 2017 at 11:21 AM, Marc Haber <mh+debian-packa...@zugschlus.de> wrote: > severity #861874 wishlist > thanks > > On Fri, May 05, 2017 at 11:11:26AM +0200, Costas Drogos wrote: >> With the upgrade to atop 2.2.6 from 1.26-2, defaults file is being >> deprecated. >> >> Thing is, with defaults deprecated and the introduction of the atop.daily >> helper, >> there is no way of configuring a different interval (and other options) >> without >> modifying the helper. >> >> So, please consider either: >> - sourcing an optional /etc/defaults/atop file, by modifying atop.daily >> - modifying atop.service to source an /etc/defaults/atop and the helper to >> check for env variables >> - provide options to the helper. e.g. --interval=150 etc. >> >> I prefer the first, as it allows for a better transition. >> I could provide patches for any of the above, if you agree so. > > Please explain why it is not acceptable to systemctl edit atop.service > or systemctl edit atopacct.service, as this is the recommended way to > modify systemd services and handles updates pretty well. >
Hi Marc, thanks for the quick answer! I could modify atop.service/atopacct.service, but I still can't override $INTERVAL and keeping atop.daily. The only way to do so is to modify ExecStart to my own custom command and lose any atop.daily functionality that is or will be there in the future. (that's what I do now). If that's what you'd prefer for custom setups, I have no problem with continuing to do so; but when dist-upgrading jessie -> stretch, atop may break/change behaviour for anyone having custom options, so a NEWS entry would be nice to have at least. Thanks, Costas
