Yes, correct.
Also you can kill the warnings and $(mkdir should be $(shell mkdir
I need to fix that in tideways package...
Ondřej
On 4 May 2017 21:00:21 Nish Aravamudan <nish.aravamu...@canonical.com> wrote:
On 04.05.2017 [10:40:50 +0200], Ondřej Surý wrote:
Source: sassphp
Followup-For: Bug #861637
Rhonda,
like in the attached patch.
Sorry for not having a better documentation, but I am extremely bad at
documenting my own work. (Would be happy to accept any patches that
makes the documentation of dh-php better though.)
I think there is one mistake in the patch, unrelated to my other
comment:
diff --git a/debian/php7.0-sassphp.php b/debian/php-sassphp.php
similarity index 50%
rename from debian/php7.0-sassphp.php
rename to debian/php-sassphp.php
index b102494..228bf89 100644
--- a/debian/php7.0-sassphp.php
+++ b/debian/php-sassphp.php
@@ -1,2 +1 @@
-mod modules/sass.so
mod debian/sass.ini
I believe the file should be debian/php-sass.php ? To match what is in
d/control. Without this, it appear that php-sass only contains the .so
file, but there is no /etc/php/7.1/mods-available/sass.ini created.
Thanks,
Nish
