That's:

PECL_SOURCE=$(filter-out debian $(DIR_TARGETS),$(wildcard *)) +$(foreach ver,$(DH_PHP_VERSIONS),$(eval PECL_SOURCE_$(ver) := $(PECL_SOURCE)))

So something else must be going on there. I have successfully built sass for coinstallable php 5.6, 7.0 and 7.1.

Cheers,
Ondřej


On 4 May 2017 6:28:02 p.m. Nish Aravamudan <nish.aravamu...@canonical.com> wrote:

Hi Ondřej,

It appears that this patch assumes a normal PECL extension and I'm not
sure sass is one?

The build eventually fails with:
cp -a undefined build-7.1
cp: cannot stat 'undefined': No such file or directory
/usr/share/dh-php/pkg-pecl.mk:60: recipe for target 'configure-7.1-stamp' failed
make[1]: *** [configure-7.1-stamp] Error 1

from dh-php.mk:

configure-%-stamp:
        cp -a $(PECL_SOURCE_$(*)) $(SOURCE_DIR)

$(foreach ver,$(DH_PHP_VERSIONS),$(eval PECL_SOURCE_$(ver) := $(if
$(PACKAGE_XML_$(ver)),$(shell xml2 < $(PACKAGE_XML_$(ver)) | sed -ne
"s,^/package/name=,,p")-$(shell xml2 < $(PACKAGE_XML_$(ver)) | sed -ne
"s,^/package/version/release=,,p"),undefined)))

Since there is no package.xml, this results in undefined? In a quick
look through pkg-pecl.mk, I'm not seeing an obvious override for this
case?

Also, should the above resulting in undefined be a fatal error since
the build is going to eventually fail (and maybe with a better
message: "unable to determine PECL source version from package.xml"?)

Reply via email to