On 27/03/2017 08:51, Gianfranco Costamagna wrote:
control: owner -1 !
control: tags -1 moreinfo
I am looking for a sponsor for my package "python-zxcvbn":
here we are:
+python-zxcvbn (4.4.14-1) unstable; urgency=low
+
+ * New maintainer (Closes: #855638)
+
^^ remove this newline
line removed
+ * Fixed change upstream source to the active fork (Closes: #850910)
+
+ -- Sabino <sp...@onenetbeyond.org> Sat, 25 Mar 2017 15:30:28 +0100
+
+python-zxcvbn (1.0+git20130503.bc1c2d-2) UNRELEASED; urgency=medium
+
+ * Fixed VCS URL (https)
^^ merge this entry into the latest one
I don't understand this change
+
+ -- Ondřej Nový <n...@ondrej.org> Tue, 29 Mar 2016 22:28:30 +0200
and then I start the review (*really* incomplete, there is a lot of missing
stuff here)
1) the changelog misses *everything*, nobody should review a package
with such an incomplete one.
(specially because I can't understand why you did changes)
I compiled the new version of the porting, what else should I write?
2) moving away from a team maintained package to a single maintained one?
- please no.
I would not do it, but I don't know how to join the team
3) the syntax of zxcvbn (the instantiation as example), changed a lot in this
fork.
Did you check reverse dependencies?
yes, no reverse dependencies found
4) unstable during freeze is a no-no
I changed "experimental" on changelog
5) watch file is full of useless stuff
commented lines removed
6) copyright entries should be merged (both * and both debian/*)
done
7) descrition too long (you shouldn't have more than 80 chars per line
truncated
8) compat level is 10 now
changed
9) rules file has a sphinx commented documentation... why?
removed, the package has no sphinx documentation
probably a lot of stuff still need changes, but I can address it only if you
fix the above.
Gianfranco
Regards,
Sab
