control: owner -1 ! control: tags -1 moreinfo
>I am looking for a sponsor for my package "python-zxcvbn": here we are: +python-zxcvbn (4.4.14-1) unstable; urgency=low + + * New maintainer (Closes: #855638) + ^^ remove this newline + * Fixed change upstream source to the active fork (Closes: #850910) + + -- Sabino <sp...@onenetbeyond.org> Sat, 25 Mar 2017 15:30:28 +0100 + +python-zxcvbn (1.0+git20130503.bc1c2d-2) UNRELEASED; urgency=medium + + * Fixed VCS URL (https) ^^ merge this entry into the latest one + + -- Ondřej Nový <n...@ondrej.org> Tue, 29 Mar 2016 22:28:30 +0200 and then I start the review (*really* incomplete, there is a lot of missing stuff here) 1) the changelog misses *everything*, nobody should review a package with such an incomplete one. (specially because I can't understand why you did changes) 2) moving away from a team maintained package to a single maintained one? - please no. 3) the syntax of zxcvbn (the instantiation as example), changed a lot in this fork. Did you check reverse dependencies? 4) unstable during freeze is a no-no 5) watch file is full of useless stuff 6) copyright entries should be merged (both * and both debian/*) 7) descrition too long (you shouldn't have more than 80 chars per line 8) compat level is 10 now 9) rules file has a sphinx commented documentation... why? probably a lot of stuff still need changes, but I can address it only if you fix the above. Gianfranco
