Hi Adrian,
> > +-[rdc_cv_build_hostname=`hostname -f 2>/dev/null || uname -n 2>/dev/null
> > || hostname 2>/dev/null || echo "unknown"`
> > ++[rdc_cv_build_hostname=`lsb_release --short --description`
[…]
> $ lsb_release --short --description
> Debian GNU/Linux 9.0 (stretch)
> This does not at all look like a hostname, so if anything actually
> parses this as a hostname there might be trouble ahead.
Great point and well-spotted; I wonder what I was thinking...
> Assuming nothing parses the version output, in this specific case
> it looks more correct to remove the PACKAGE_BUILD_HOSTNAME usage
> in src/main.cpp.
Yes. These are typically harder to upstream, hence why I default to
simply "fixing" the hostname rather than removing them entirely when
I send patches. Maintainers can probably gauge this better; I'll
leave this to your judgement.
:)
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
