On Sun, Jul 17, 2016 at 03:56:24PM +0200, Chris Lamb wrote:
>...
> +--- tcpreen-1.4.4.orig/m4/hostname.m4
> ++++ tcpreen-1.4.4/m4/hostname.m4
> +@@ -5,7 +5,7 @@ dnl From Remi Denis-Courmont
> + AC_DEFUN([RDC_BUILD_HOSTNAME],
> + [AC_CACHE_CHECK([for build hostname],
> + rdc_cv_build_hostname,
> +-[rdc_cv_build_hostname=`hostname -f 2>/dev/null || uname -n 2>/dev/null ||
> hostname 2>/dev/null || echo "unknown"`
> ++[rdc_cv_build_hostname=`lsb_release --short --description`
> + ])
> + AC_DEFINE_UNQUOTED(PACKAGE_BUILD_HOSTNAME, "$rdc_cv_build_hostname",
> + [Define to the hostname of the host who builds the package.])
>...
$ lsb_release --short --description
Debian GNU/Linux 9.0 (stretch)
$
This does not at all look like a hostname, so if anything actually
parses this as a hostname there might be trouble ahead.
Assuming nothing parses the version output, in this specific case
it looks more correct to remove the PACKAGE_BUILD_HOSTNAME usage
in src/main.cpp (the __DATE__ usage in the same line could then
also be removed).
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
