-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hello Naveen,

On Tue, 2017-02-07 at 23:18 +0530, Naveen N. Rao wrote:
> I'm not familiar with lua/luajit, but can it be made optional forĀ 
> ppc64el and aarch64?
> 
> Upstream has a similar fix for rpm distros:
> https://github.com/iovisor/bcc/commit/ef91b6ed64d022baec977a8415581cd1a4a218c5

Thanks for the link. The RH folks are doing similar things to what I tried but
their changes are confined to the RPM build script.

That doesn't help Debian but the changes are almost the same to what I was
attempting. But I'm still curious to see how those changes fix the actual bug I
encountered. Because for non-luajit setups, the build would still fail.

Did you try building BCC on Debian with my (incomplete) patch ?
Let me pick the exact build failure.

[ 81%] Generating bcc.lua
Scanning dependencies of target test_static
cd /build/bpfcc-0.2.0/obj-x86_64-linux-gnu/src/lua && /usr/bin/lua5.3 
/build/bpfcc-0.2.0/src/lua/src/squish.lua /build/bpfcc-0.2.0/src/lua
make[3]: Leaving directory '/build/bpfcc-0.2.0/obj-x86_64-linux-gnu'
make -f tests/cc/CMakeFiles/test_static.dir/build.make 
tests/cc/CMakeFiles/test_static.dir/build
Writing bcc.lua...
OK!
make[3]: Entering directory '/build/bpfcc-0.2.0/obj-x86_64-linux-gnu'
[ 83%] Generating bcc.o
cd /build/bpfcc-0.2.0/obj-x86_64-linux-gnu/src/lua && /usr/bin/lua5.3 bcc.lua 
bcc.o
/usr/bin/lua5.3: bcc.lua:1656: ')' expected near 'ULL'
src/lua/CMakeFiles/bcc-lua.dir/build.make:64: recipe for target 'src/lua/bcc.o' 
failed
make[3]: *** [src/lua/bcc.o] Error 1
[ 85%] Building C object tests/cc/CMakeFiles/test_static.dir/test_static.c.o
make[3]: Leaving directory '/build/bpfcc-0.2.0/obj-x86_64-linux-gnu'
CMakeFiles/Makefile2:676: recipe for target 
'src/lua/CMakeFiles/bcc-lua.dir/all' failed
make[2]: *** [src/lua/CMakeFiles/bcc-lua.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
cd /build/bpfcc-0.2.0/obj-x86_64-linux-gnu/tests/cc && /usr/lib/ccache/cc   
-I/usr/lib/llvm-3.8/include/../tools/clang/include -I/build/bpfcc-0.2.0/src/cc  
-g -O2 -fdebug-prefix-map=/build/b
pfcc-0.2.0=. -fstack-protector-strong -Wformat -Werror=format-security -no-pie 
-Wdate-time -D_FORTIFY_SOURCE=2 -Wall -O3 -DNDEBUG   -o 
CMakeFiles/test_static.dir/test_static.c.o   -c /build/
bpfcc-0.2.0/tests/cc/test_static.c
[ 87%] Linking CXX executable test_static



The same code builds fine with luajit. So that begs the question of what Lua
does different than Luajit.

Can someone help me with the following ?

* What is the luajit equivalent in Lua? Lua has `luac` and `lua5.3`, which are
the compiler and the interpreter respectively.
* Command option equivalent.

        ADD_CUSTOM_COMMAND(
                OUTPUT bcc.o
                COMMAND ${LUAJIT} -bg bcc.lua bcc.o
                DEPENDS bcc.lua
        )

For luajit, "-bg" is understood. What we need is the equivalent of it in
lua/luac.


- -- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQCVDstmIVAB/Yn02pjpYo/LhdWkFAliaFA8ACgkQpjpYo/Lh
dWkM8Q//SNcAAZ0iojISqOzmUAy46u5WLz7NFc4COiML5X5Bmn6M0yWp5zyzB+NM
npEd3bpXENFm+PLLor6AZElWp6jSUxDfmyH1oQb1ZjzfwFRDSrEAq08uabYDspxe
JWMK49g49/swiiEoxQcc+WZ+5PNoUPEz0Xvg/TC0PksbUrurKDfxveKvo/1ic3Hp
ZpdMANsu94VSyDAAxPFeWpFXH0BxELaDNiznz9B3fHi0jywkdxVUUxhjZkwO/Rig
xMv2ihuRNNu73365Y0V/2NrC89s0B6Bcl080GKsjfyOvQsnun8E3pJ9uvATDpSaH
SP+wEHJmG89xuLWlSdCKyqRQoRZHPg5wq7RUBSKngHxnWzbJGSU3QOwcsHUj3X7O
llH86hGap3XI3rU5ug5G1tTjGPY655750PEInUecYR/BmqPfsp4lE+oGweH1GHAn
YB7RhLMQvyIWb44v037qdu+eIzn7UGowpVP0+MFGXxh09abU0+csu1o7bag76OHZ
Jw+kJQWCXGcby2gJKo/z5dddBsc/6MI5OyS7QX0LP4yrINfRiPUL9DuKOO3BVBRU
Qn2xLQs6vuMW/UWL0/n1uNQyoaDH/D1SSvy2zApatN4XrGpWv8rTSfX2yDwitwi3
1NXb+qFulaiez3v+w00qFcDLNLyj8VkYfSrgaUm0PrTJB4J8CXg=
=fT56
-----END PGP SIGNATURE-----

Reply via email to