On Thu, 26 Jan 2017, Ian Jackson wrote:
I don't think the git format permits commas here. After removing that
line and doing a fetch, please try `git fsck' ?
git doesn't complain. Re-running everything in sid, with the
search/replace line in dgit commented out:
root@c941f608556e:~/scm# git log 228fbe | head -n 3
commit 228fbe98a09928fe99b60b6a03d49e8487251c4a
Author: Thomas Bushnell, BSG <t...@debian.org>
Date: Tue Feb 5 01:53:13 2008 +0000
root@c941f608556e:~/scm# git fsck --strict --full
Checking object directories: 100% (256/256), done.
root@c941f608556e:~/scm# git --version
git version 2.11.0
Despite this, I could still imagine that comma causing problems in other
tooling.
I think the fix to this will be rather more complicated.
The following line strips the comma-and-suffix in this one particular
case, while keeping the email:
$author =~ s#,.*<# <#ms;
I don't understand the original motivation for stripping comma-and-suffix
though. At first I assumed it was to reduce to a single maintainer if
there were multiple maintainers listed, but that seems against
debian-policy (linked before). Do you know/remember what this
search/replace is trying to achieve?
I'm also confused about the combination of the 'm' and 's' modifiers:
m Treat string as multiple lines.
s Treat string as single line.
--bryan
