Source: android-platform-system-core
Version: 6.0.1+r55
Severity: normal

Dear Maintainer,

I was very pleased to see that this package had build-profile info for
untangling the bootstrap of this and android-platform-system-extras.

However when I tried using it I found that it didn't build.

android-libunwind-dev is needed (by libbacktrace), which is needed by libutils.

I don't know if it could be removed, but it seemed tricky, and as
android-libunwind-dev comes from a separate source with minimal
build-deps there seems to be no need to skip this build-dep. So I put it back.

Similarly libsafe-iop-dev is needed too and is not obvisoulypart of a
loop so I put that back.

Now it builds but tries to use pango for the manpages and so fails.

not using pango should use the 'nodoc' build profile rather than the
'stage1' profile as that is more specific. So I changed that and fixed
up the rules files not to run those rules. And use dh-exec to avoid
dh_installman trying to install non-existent manpages.

Now it works. 

You can test it with 
apt-get -P stage1,nodoc build-dep android-platform-system-core
cd android-platform-system-core-*
dpkg-buildpackage -Pstage1,nodoc

Hope this is useful.

There is still a bootstrapping issue with the self-dependency on 
android-platform-system-core-headers

not sure if there is any build magic to generate those, or build without them?

-- 
Wookey
diff -Nru android-platform-system-core-6.0.1+r55/debian/adb.manpages android-platform-system-core-6.0.1+r55/debian/adb.manpages
--- android-platform-system-core-6.0.1+r55/debian/adb.manpages	2016-07-21 19:07:25.000000000 +0000
+++ android-platform-system-core-6.0.1+r55/debian/adb.manpages	2016-09-22 04:50:10.000000000 +0000
@@ -1 +1 @@
-debian/adb.1
\ No newline at end of file
+#!/usr/bin/dh-exec\n<!nodoc> debian/adb.1\n
\ No newline at end of file
diff -Nru android-platform-system-core-6.0.1+r55/debian/changelog android-platform-system-core-6.0.1+r55/debian/changelog
--- android-platform-system-core-6.0.1+r55/debian/changelog	2016-07-21 19:07:25.000000000 +0000
+++ android-platform-system-core-6.0.1+r55/debian/changelog	2016-09-22 04:37:09.000000000 +0000
@@ -1,3 +1,10 @@
+android-platform-system-core (1:6.0.1+r55-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix stage1 build so it works
+
+ -- Wookey <woo...@debian.org>  Thu, 22 Sep 2016 04:36:58 +0000
+
 android-platform-system-core (1:6.0.1+r55-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru android-platform-system-core-6.0.1+r55/debian/control android-platform-system-core-6.0.1+r55/debian/control
--- android-platform-system-core-6.0.1+r55/debian/control	2016-07-21 19:07:25.000000000 +0000
+++ android-platform-system-core-6.0.1+r55/debian/control	2016-09-22 04:39:22.000000000 +0000
@@ -7,14 +7,14 @@
            Chirayu Desai <chirayudes...@gmail.com>
 Build-Depends: android-libext4-utils-dev (>= 6.0.1+r16-2) [amd64 i386] <!stage1>,
                android-libf2fs-utils-dev (>= 6.0.1+r16-2) [amd64 i386]  <!stage1>,
-               android-libunwind-dev (>= 6.0.1+r55~) [amd64 i386] <!stage1>,
+               android-libunwind-dev (>= 6.0.1+r55~) [amd64 i386],
                android-platform-build-headers (>= 1:6.0.1+r16-4),
                debhelper (>= 9.20141010),
                dh-exec,
                dpkg-dev (>= 1.17.14),
-               libsafe-iop-dev [amd64 i386] <!stage1>,
+               libsafe-iop-dev [amd64 i386],
                libssl-dev [amd64 i386] <!stage1>,
-               pandoc [amd64 i386] <!stage1>,
+               pandoc [amd64 i386] <!nodoc>,
                zlib1g-dev [amd64 i386] <!stage1>
 Standards-Version: 3.9.8
 Homepage: https://android.googlesource.com/platform/system/core
diff -Nru android-platform-system-core-6.0.1+r55/debian/fastboot.manpages android-platform-system-core-6.0.1+r55/debian/fastboot.manpages
--- android-platform-system-core-6.0.1+r55/debian/fastboot.manpages	2016-07-21 19:07:25.000000000 +0000
+++ android-platform-system-core-6.0.1+r55/debian/fastboot.manpages	2016-09-22 04:50:30.000000000 +0000
@@ -1 +1 @@
-debian/fastboot.1
\ No newline at end of file
+#!/usr/bin/dh-exec\n<!nodoc> debian/fastboot.1\n
\ No newline at end of file
diff -Nru android-platform-system-core-6.0.1+r55/debian/rules android-platform-system-core-6.0.1+r55/debian/rules
--- android-platform-system-core-6.0.1+r55/debian/rules	2016-07-21 19:07:25.000000000 +0000
+++ android-platform-system-core-6.0.1+r55/debian/rules	2016-09-22 04:40:10.000000000 +0000
@@ -58,8 +58,11 @@
 	dh $@
 
 override_dh_auto_build: $(COMPONENTS)
+#skip pango usage in stage1
+ifeq ($(filter nodoc,$(DEB_BUILD_PROFILES)),)
 	pandoc -s -o debian/adb.1 debian/adb.1.md
 	pandoc -s -o debian/fastboot.1 debian/fastboot.1.md
+endif
 
 override_dh_auto_clean:
 	dh_auto_clean

Reply via email to