Hi GSR, On Sat, Aug 13, 2016 at 09:44:45PM +0200, GSR wrote: > firejail seems to force PS1. A grep in the git source shows it is done > by setting PROMPT_COMMAND (!?) in two different places (join.c and > env.c), but no explanation why in source or documentation. > > If there is a security reason to force PS1 (or even the roundabout way > with PROMPT_COMMAND) it should be documented. Also using only colors > to inform of something can backfire, not all terminals support them. > > Otherwise PS1 and PROMPT_COMMAND should be left under shell control > from the start. They can be overridden once you figure what is going > on anyway, and I would had not noticed anything if I had used > PROMPT_COMMAND for something.
I will ask upstream about the reason to change the prompt and if it
can be made optional.
> While investigating this, I found out ${container} env var too with a
> comment talking about Linux Containers. LXC doesn't seem to document
> that one either, and the ones documented follow the standard of all
> upper case (LXC_*), so I also have doubts about its correctness (some
> left over from a LXC script? bug and will be fixed to be upper case?).
The "container" variable is named correctly. LXC and other container
technologies (docker, systemd-nspawn, etc.) export it, to indicate that
a process is running containerized, see also [1].
[1]: https://www.freedesktop.org/wiki/Software/systemd/ContainerInterface/
signature.asc
Description: Digital signature
