Package: firejail
Version: 0.9.40-3
Severity: normal

Dear Maintainer,

firejail seems to force PS1. A grep in the git source shows it is done
by setting PROMPT_COMMAND (!?) in two different places (join.c and
env.c), but no explanation why in source or documentation.

If there is a security reason to force PS1 (or even the roundabout way
with PROMPT_COMMAND) it should be documented. Also using only colors
to inform of something can backfire, not all terminals support them.

Otherwise PS1 and PROMPT_COMMAND should be left under shell control
from the start. They can be overridden once you figure what is going
on anyway, and I would had not noticed anything if I had used
PROMPT_COMMAND for something.

While investigating this, I found out ${container} env var too with a
comment talking about Linux Containers. LXC doesn't seem to document
that one either, and the ones documented follow the standard of all
upper case (LXC_*), so I also have doubts about its correctness (some
left over from a LXC script? bug and will be fixed to be upper case?).

Thanks,
GSR

-- System Information:
Debian Release: 8.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.4.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages firejail depends on:
ii  libc6  2.23-4

Versions of packages firejail recommends:
pn  xpra | xserver-xephyr  <none>

firejail suggests no packages.

-- no debconf information

Reply via email to