Hi Gianfranco! On 6 July 2016 at 05:17, Gianfranco Costamagna <locutusofb...@debian.org> wrote: >>I'd say the important points to convey are "1. many contributors, 2. GPL2". > > > Actually I agree, I try to sum up files for licenses, instead of copyright > holders > e.g. > all the autoconf* stuff, can go in a single file > and many copyright headers listed in that section. ... > so, as all the autoconf files, you might try to put them under the same > copyright > section.
Ok, so group primarily according to licenses, then functionality/subsection? eg: autoconf* stuff, send|receive stuff, subsystem a stuff, subsystem b stuff? > Another thing, you might consider to change > Files: debian/* > Copyright: 2007-2012, Daniel Baumann > <daniel.baum...@progress-technologies.net> > License: GPL-2+ > > Files: debian/watch > Copyright: 2016, Nicholas D Steeves <nstee...@gmail.com> > License: GPL-2 > > > into something like > Files: debian/* > Copyright: 2007-2012, Daniel Baumann > <daniel.baum...@progress-technologies.net> > 2016, Nicholas D Steeves <nstee...@gmail.com> > > License: GPL-2+ > > > (and add xnox maybe :) ) Done, in my working copy. > some more "contraction" might be e.g. > Files: send-test.c > Copyright: 2013, SUSE <http://www.suse.com/> > 2012, Alexander Block. > License: GPL-2 > > Files: send.h > Copyright: 2012, STRATO <http://www.strato.com/> > 2012, Alexander Block. > License: GPL-2 > > Files: ulist.c > ulist.h > Copyright: 2011, STRATO <http://www.strato.com/> > License: GPL-2 > > this can become > > Files: send-test.c send.h ulist.c ulist.h > Copyright: 2013, SUSE <http://www.suse.com/> > 2011-2012, STRATO <http://www.strato.com/> > 2012, Alexander Block. > License: GPL-2 So in this case the rule is group by individual, after grouping by license, but list corporation first? > > lets review something more: > +++ btrfs-progs-4.5.3/debian/btrfs-progs.changelogs 2016-07-01 > 13:01:45.000000000 +0200 > @@ -0,0 +1 @@ > +CHANGES > > > mmm such files should be automatically picked up by debhelper... > I would say this file is useless :) ;-) The CHANGES file wasn't being automatically picked up when I built the package, on either sid, testing, or as a jessie-backport. This surprised me, and I read that package.changelogs was the cleanest way to give debhelper a hint without using an override in rules. Also, faster to remove whenever debhelper starts automatically finding it! > +++ btrfs-progs-4.5.3/debian/upstream/signing-key.asc 2016-07-01 > 13:01:45.000000000 +0200 > > > YAY! :-) Finally, right?! > +++ btrfs-progs-4.5.3/debian/watch 2016-07-01 13:35:15.000000000 +0200 > > + > > > spurious newline at the end :) Fixed! Ay ya yai that copyright file is tricky... Do you think I should maybe just rebase off of the original and apply only the most essential changes? Cheers! Nicholas
