Hi, I split the ufw parts as we discussed. This will give us at Ubuntu a little transition when we merge back next time, but these files are almost never modified so it should be straight forward. Better do the right thing now :-)
I created and attached a debdiff for your review and consideration. I built it and ensured in a sid container that upgrades with these new debs work. I also verified that it shows up in "ufw app" commands after the upgrade. Kind Regards, Christian Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Thu, Jun 30, 2016 at 7:13 AM, Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > On Thu, Jun 30, 2016 at 12:07 AM, Jaldhar H. Vyas <jald...@debian.org> > wrote: > >> On Tue, 28 Jun 2016, Christian Ehrhardt wrote: >> >> Package: dovecot >>> Version: 1:2.2.24-1 >>> >>> Hi, >>> I was currently merging dovecot for Ubuntu and I thought it really is >>> time >>> to provide some of the delta for your benefit as well. >>> Some of them are more "Ubuntu'ish" pieces apport and ufw integration. >>> But still those things exist and make sense in Debian as well . >>> And since it is up to you to accept (or not) anyway I should at least >>> suggest it. >>> >>> >> It's a good idea. We haven't synchronized the Debian and Ubuntu packages >> for a long time. >> >> I wanted to suggest the following three changes for your review and >>> inclusion: >>> >>> 1. lsb-base ad dependency. >>> There is even a comment in the init script, but no dependency: >>> debian/dovecot-core.dovecot.init:46:# Depend on lsb-base (>= 3.0-6) to >>> ensure that this file is present. >>> debian/dovecot-core.dovecot.init:47:. /lib/lsb/init-functions >>> Usually "some" packet always refers to lsb-base but I was able to break >>> it >>> in a sid containter by doing "apt-get remove lsb-base cron logrotate". >>> That makes /lib/lsb/init-functions unavailable. >>> >>> Fix is as easy as: >>> https://git.launchpad.net/~paelzer/ubuntu/+source/dovecot/commit/?h=merge&i >>> d=f06699c206667998f4356b4b66bd7bee77b3ebbf >>> >> >> I have added this. >> >> >>> 2. ufw integration >>> Just allowing easy ufw integration can always be useful to users. >>> See the changeat >>> https://git.launchpad.net/~paelzer/ubuntu/+source/dovecot/commit/?h=merg >>> e&id=2f445a7f8bdb9f18bdfe39cd55014bdd42447bb8 >>> >>> >> Question: Why is the ufw support in dovecot-core? Wouldn't it be more >> sensible to put the appropriate pieces in dovecot-imapd and dovecot-pop3d >> respectively? I am not very familiar with ufw so forgive me if this a >> silly question. >> > > Not at all a silly question. > I mean I came to that delta like finding it - which is good as I have no > parental-love to that code as-is :-) > Giving your suggestion a thought I'd agree that it would be nicer to split > it to the respective sub-components. > > Thanks for already adding the other two diffs already - I'll submit a > debdiff of the splitted ufw integration somewhen later today. > > > >> 3. apport hooks >>> Good if you would like to enable extra data on apport. While not the >>> common >>> Debian way the change would be not very intrusive - so please take a >>> look. >>> Seehttps:// >>> git.launchpad.net/~paelzer/ubuntu/+source/dovecot/commit/?h=merge&i >>> d=6b0ed49af2b9b79ce8147f390e0f343eb4e71518 >>> >>> >> This one also seems ok to me. Added. >> >> There are slight merge conflicts to last debian due to the fact that these >>> commits are in the midst of more ubuntu delta. But I can provide a >>> cleaned >>> diff, debdiff or whatever you want after we had a discussion if you >>> actually >>> would like the changes. >>> >>> >> debdiff would probably be the easiest or git commits I could cherry-pick >> from. But definitely do keep suggesting changes. They are very helpful. > > > Ok, good to know. > We have some more delta like a great ADT, but it is tied up closely to > some other changes we make - and I intend to drop eventually. > Not for this cycle, but probably next one - I hope we gonna drop this > functional delta, convert that ADT to match the package as in debian and > then provide that to you as well. > > Thanks already - I'll be back later with a debdiff for the ufw things. >
ufw-split-debian-sid.debdiff
Description: Binary data
