On Tue, 28 Jun 2016, Christian Ehrhardt wrote:
Package: dovecot
Version: 1:2.2.24-1
Hi,
I was currently merging dovecot for Ubuntu and I thought it really is time
to provide some of the delta for your benefit as well.
Some of them are more "Ubuntu'ish" pieces apport and ufw integration.
But still those things exist and make sense in Debian as well .
And since it is up to you to accept (or not) anyway I should at least
suggest it.
It's a good idea. We haven't synchronized the Debian and Ubuntu packages
for a long time.
I wanted to suggest the following three changes for your review and
inclusion:
1. lsb-base ad dependency.
There is even a comment in the init script, but no dependency:
debian/dovecot-core.dovecot.init:46:# Depend on lsb-base (>= 3.0-6) to
ensure that this file is present.
debian/dovecot-core.dovecot.init:47:. /lib/lsb/init-functions
Usually "some" packet always refers to lsb-base but I was able to break it
in a sid containter by doing "apt-get remove lsb-base cron logrotate".
That makes /lib/lsb/init-functions unavailable.
Fix is as easy
as:https://git.launchpad.net/~paelzer/ubuntu/+source/dovecot/commit/?h=merge&i
d=f06699c206667998f4356b4b66bd7bee77b3ebbf
I have added this.
2. ufw integration
Just allowing easy ufw integration can always be useful to users.
See the changeat
https://git.launchpad.net/~paelzer/ubuntu/+source/dovecot/commit/?h=merg
e&id=2f445a7f8bdb9f18bdfe39cd55014bdd42447bb8
Question: Why is the ufw support in dovecot-core? Wouldn't it be more
sensible to put the appropriate pieces in dovecot-imapd and dovecot-pop3d
respectively? I am not very familiar with ufw so forgive me if this a
silly question.
3. apport hooks
Good if you would like to enable extra data on apport. While not the common
Debian way the change would be not very intrusive - so please take a look.
Seehttps://git.launchpad.net/~paelzer/ubuntu/+source/dovecot/commit/?h=merge&i
d=6b0ed49af2b9b79ce8147f390e0f343eb4e71518
This one also seems ok to me. Added.
There are slight merge conflicts to last debian due to the fact that these
commits are in the midst of more ubuntu delta. But I can provide a cleaned
diff, debdiff or whatever you want after we had a discussion if you actually
would like the changes.
debdiff would probably be the easiest or git commits I could cherry-pick
from. But definitely do keep suggesting changes. They are very helpful.
--
Jaldhar H. Vyas <jald...@debian.org>
