Control: reopen -1
Hi!
On Thu, 2016-04-07 at 16:36:09 +0200, Gianfranco Costamagna wrote:
> Package: slang2
> Version: 2.3.0-2
> Severity: important
> Tags: patch pending
> I've prepared an NMU for slang2 (versioned as 2.3.0-2.1) and
> uploaded it to DELAYED/5. Please feel free to tell me if I
> should delay it longer.
> diff -Nru slang2-2.3.0/debian/control slang2-2.3.0/debian/control
> --- slang2-2.3.0/debian/control 2014-09-22 11:23:21.000000000 +0200
> +++ slang2-2.3.0/debian/control 2016-04-07 16:33:26.000000000 +0200
> @@ -52,7 +52,7 @@
> Pre-Depends: ${misc:Pre-Depends}
> Multi-Arch: same
> Built-Using: ${Built-Using}
> -Recommends: libpng12-0
> +Recommends: libpng16-16
> Description: S-Lang programming library - runtime version
> S-Lang is a C programmer's library that includes routines for the rapid
> development of sophisticated, user friendly, multi-platform applications.
>
I don't think this was the right fix, because this kind of Recommends
is wrong in two accounts. First the module using this shared library is
shipped in the libslang2-modules, so the dependency is useless here. And
second, hardcoding the shared library name means each time the SONAME
changes this package has to be patched manually (making transitions
harder as binNMUs do not work here), when dpkg-shlibdeps has all the
required information to infer the correct dependency by using
-dRecommends for example.
Please use the attached patch to properly fix this so that we don't
need to touch this on the next transition! :)
Thanks,
Guillem
From 73d25b72d5fd5a9016867276336b9c205566ef08 Mon Sep 17 00:00:00 2001
From: Guillem Jover <guil...@debian.org>
Date: Fri, 8 Apr 2016 18:08:57 +0200
Subject: [PATCH] Remove incorrectly hardcoded shared library package from
Recommends
This is wrong in two accounts. First the module using this shared
library is shipped in the libslang2-modules, so the dependency is
useless here. And second, hardcoding the shared library name means
each time the SONAME changes this package has to be patched manually,
when dpkg-shlibdeps has all the required information to infer the
correct dependency by using -dRecommends for example.
---
debian/control | 1 -
1 file changed, 1 deletion(-)
diff --git a/debian/control b/debian/control
index 8122cb4..1f00d93 100644
--- a/debian/control
+++ b/debian/control
@@ -52,7 +52,6 @@ Depends: ${shlibs:Depends}, ${misc:Depends}
Pre-Depends: ${misc:Pre-Depends}
Multi-Arch: same
Built-Using: ${Built-Using}
-Recommends: libpng16-16
Description: S-Lang programming library - runtime version
S-Lang is a C programmer's library that includes routines for the rapid
development of sophisticated, user friendly, multi-platform applications.
--
2.8.0.rc3
