Dear Bjarni,

Thanks for your report and the patch, and sorry that you did not get
a more prompt reply to your report.

As Tobias has mentioned, the patch no longer cleanly applies. However
many of the hunks do. I was just going through a diff of the successful
parts to see what made it. Responding to your notes:

On Mon, Apr 16, 2012 at 07:53:29PM +0000, Bjarni Ingi Gislason wrote:
>   One space between sentences changed to two,

This is a substantial amount of the patch (in lines-changed terms).
Is there a technical reason for this? Afaik it's a matter of style,
and one that upstream may not agree with. (It seems the state of
the file before your changes is to have a mixture of one space or
two, so I guess being consistent one way or the other is a good
thing).

My hope is that we can get most of your work merged upstream so that
Debian is not carrying a patch forever; I'm not sure whether to push
forward the double-space-after-period changes.

Once I've gone through the .rej file and got the other half of the
patch re-applied (or not) I'll add it to the pending upload and ping
upstream about it.


-- 
Jonathan Dowland

Reply via email to