On Thu, Jan 07, 2016 at 07:33:38PM -0500, James McCoy wrote: > On Mon, Dec 28, 2015 at 11:27:28AM +0100, Ph. Marek wrote: > > During a run with my automated test suite for FSVS I noticed that some > > things that previously worked do not any more. > > I can't really give a hard range of SVN versions, but I guess 2 or 3 years > > ago that wasn't a problem yet ;/ > > Hmmm. I tested all the way back to SVN 1.5 and I either get the abort > you're reporting or a failure trying to setup the working copy in order > to run the test.
Ok, during SVN 1.7 development (r957893) moved a bunch of code from svn_ra_local__split_URL to a new function, svn_uri_get_dirent_from_file_url. When that happened, the assert you're hitting was added: assert(svn_uri_is_canonical(url, pool)); You're not canonicalizing the URL before passing it into svn_ra_open(). You probably want to use svn_path_canonicalize() (or if you can accept a minimum SVN version of 1.6, one of svn_dirent_canonicalize, svn_uri_canonicalize, svn_relpath_canonicalize) in url__parse instead of manually trying to make it canonical. Granted, the assert is new but it's just asserting the contract of the APIs. The URIs were always supposed to be canonicalized. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <james...@debian.org>
