On 27/10/15 18:20, Vagrant Cascadian wrote: > On 2015-10-27, Emilio Pozuelo Monfort wrote: >> The attached patch creates a rockchip package and enables the >> firefly-rk3288 platform. > > Thanks! > > >> rock2-rk3288 and rock2-sd-rk3288 are commented out for now as those >> are not upstreamed yet. > > I'd rather leave them out entirely until they're supported. > > >> Sjoerd (Cc'ed) is working upstream on this, and has volunteered >> to keep this working / test new versions. I will be happy to do >> that too, so long as I still have the hardware. > > Great! > > >> diff -ruNp -x '*patch' u-boot-2015.10~rc4+dfsg1/debian/rules >> u-boot-2015.10+dfsg1/debian/rules >> --- u-boot-2015.10~rc4+dfsg1/debian/rules 2015-09-29 01:02:28.000000000 >> +0200 >> +++ u-boot-2015.10+dfsg1/debian/rules 2015-10-27 13:36:03.145766654 >> +0100 >> @@ -56,6 +56,11 @@ override_dh_auto_build: >> echo $$builddir/$$target >> /usr/lib/u-boot/$$platform/ \ >> >> debian/build/targets.$$subarch; \ >> done ;; \ >> + rockchip) \ >> + echo $$builddir/spl/u-boot-spl-dtb.rksd >> /usr/lib/u-boot/$$platform/ \ >> + >> debian/build/targets.$$subarch; \ >> + echo $$builddir >> debian/build/rksd; \ >> + ;; \ >> esac; \ >> done >> >> @@ -79,6 +84,10 @@ override_dh_auto_build: >> $(CROSS_COMPILE)strip --remove-section=.comment $(TOOLSDIR)/tools/kwboot >> $(CROSS_COMPILE)strip --remove-section=.comment >> $(TOOLSDIR)/tools/mksunxiboot >> >> + set -e; for platform in `cat debian/build/rksd`; do \ >> + $(TOOLSDIR)/tools/mkimage -T rksd -d >> $$platform/spl/u-boot-spl-dtb.bin $$platform/spl/u-boot-spl-dtb.rksd; \ >> + done >> + >> override_dh_auto_test: >> # skip tests. >> > > Unfortunately, the patch FTBFS for me: > > arm-linux-gnueabihf-strip --remove-section=.comment > debian/build/tools/tools/kwboot > arm-linux-gnueabihf-strip --remove-section=.comment > debian/build/tools/tools/mksunxiboot > set -e; for platform in `cat debian/build/rksd`; do \ > debian/build/tools/tools/mkimage -T rksd -d > $platform/spl/u-boot-spl-dtb.bin $platform/spl/u-boot-spl-dtb.rksd; \ > done > /bin/sh: 2: debian/build/tools/tools/mkimage: not found > make[1]: *** [override_dh_auto_build] Error 127 > debian/rules:30: recipe for target 'override_dh_auto_build' failed > make[1]: Leaving directory '/«BUILDDIR»/u-boot-2015.10+dfsg1' > make: *** [build] Error 2
I guess you're cross-building? mkimage was just stripped, so it should exist. It fails to run because it's an ARM binary but you're on amd64... or so I guess :) The "not found" error is just misleading and what happens when you try to run an ELF binary from another architecture that your system doesn't support. > I'm wondering if it wouldn't be cleaner to add support to upstream's > Makefile to build u-boot-spl-dtb.rksd images, rather than muck around in > debian/rules? Or simply document the process to generate the rksd images > in README.Debian? Sjoerd, what do you think? Cheers, Emilio
