On 1 September 2015 at 15:51, Jose M Calhariz <jose.calha...@tecnico.ulisboa.pt> wrote: > Hi Felipe, > > On Tue, Sep 01, 2015 at 03:23:14PM -0300, Felipe Sateler wrote: >> On 1 September 2015 at 15:13, Jose M Calhariz >> <jose.calha...@tecnico.ulisboa.pt> wrote: >> > Hi Felipe, >> > On Tue, Sep 01, 2015 at 10:25:28AM -0300, Felipe Sateler wrote:
>> >> 2. I think you also need /var/log in RequiresMountsFor >> > >> > I am not certain. switchconf don't write directly to the /var/log. >> > It uses the command logger to write via syslog. It is not be better >> > to depend on the syslog service than to depend on /var/log. I am just >> > asking. >> >> It seems to me that it does write: >> >> http://sources.debian.net/src/switchconf/0.0.9-2/switchconf/#L41 > > Since version 0.0.10, not yet on Debian, it uses logger. Here is a > fragment from version 0.0.14 that I intend to upload to Debian: > <snip code> Ah, sorry I missed it was a different version. Excellent, then indeed the /var/log in RequiresMountsFor should not be needed. The logging daemon should take care of making sure /var/log is writable before writing there. >> >> >> >> >> Otherwise looks OK! >> >> >> > >> > In attach is the complete switchconf.service, for the people that come >> > later in this discussion. >> >> Looks good to me! >> >> > > Thank you for the review. Thank you for taking care of switchconf. -- Saludos, Felipe Sateler
