Hi Jose,

On 1 September 2015 at 07:09, Jose M Calhariz
<jose.calha...@tecnico.ulisboa.pt> wrote:
> Hi,
>
> I have created a systemd service unit for switchconf.  While waiting
> for my sponsor to upload the new version, it's possible to download a
> preview from my blog: http://blog.calhariz.com.

It helps reviewers if you attach a diff or at least the file ;). Some comments:

1. Please replicate the skip conditions in the service file using
ConditionKernelCommandLine. Check systemd.unit(5) for details. This
way systemd skips your script itself.
2. I think you also need /var/log in RequiresMountsFor

Otherwise looks OK!

-- 

Saludos,
Felipe Sateler

Reply via email to