On Thu, Jul 09, 2015 at 08:06:52PM +0530, Balasankar C wrote: > Currently, wnpp-check does a regex match on package names which returns true > if > the searched text is found somewhere in the list of packages with ITP/RFP. > Example : `wnpp-check ruby-grape` will return true with an RFP filed on > ruby-grape-entity. > This is because of the use of grep in wnpp-check. > > However, there are scenarios where we want wnpp-check to return true only if > the > exact package name that we search for is found. That is, `wnpp-check > ruby-grape` > should return false. One of such scenario I am facing is when I am checking > which all dependencies of gitlab are packaged. As part of it, I take a list > of dependencies > and do wnpp-check on them. Based on the result, I generate a progressbar [1]. > However, this gives false positives as explained above. > > The attached patch is one way to fix the issue. By adding a --exact/-e option > to tackle this scenario. Please use it if it meets the coding standards or be > kind > enough to add such an option.
There is not something like "coding standards" for devscripts, it's bore out of
random scripts collected into a package.
Expecially for a script like wnpp-check...
Would you also add something to the --help and the manpage?
I suggest also you to clone the devscripts git repository to easy diff your
patches (`git diff`, `git format-patch`,...)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: Digital signature
