Hi Andrey,

Thanks a lot for the review. I've fixed most of the reported errors (sorry 
I did not checked enough my package before uploading it).

On 06/09/2015 07:45 PM, Andrey Rahmatullin wrote:
> Control: tags -1 + moreinfo
> debian/man and debian/man/man/ look unnecessary. 

Not sure how these debian/man[/man] directories arrived in my source package, 
but I'll be more careful now.

> examples are usually installed by dh_installexamples instead of
> dh_installdocs.
> You shouldn't have multiple copies of a license in d/copyright.
> The build log says "W: dh_python2:479: Please add dh-python package to
> Build-Depends"
> 
> Also, lintian shows a lot of problems:
> 
> P: circus source: unversioned-copyright-format-uri 
> http://dep.debian.net/deps/dep5
> W: circus source: dep5-copyright-license-name-not-unique (paragraph at line 
> 26)
> P: circus source: debian-watch-may-check-gpg-signature
> P: circus: no-upstream-changelog
> I: circus: capitalization-error-in-description python Python
> W: circus: package-install-into-obsolete-dir etc/bash_completion.d/ : 
> ^etc/bash_completion.d/ -> usr/share/bash-completion/completions (see also 
> https://bugs.debian.org/776954)
> W: circus: package-install-into-obsolete-dir 
> etc/bash_completion.d/circusctl_bash_completion : ^etc/bash_completion.d/ -> 
> usr/share/bash-completion/completions (see also 
> https://bugs.debian.org/776954)
> I: circus: init.d-script-does-not-provide-itself etc/init.d/circus
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus-plugin.1.gz 
> allows to allows one to
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz managment 
> management
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz usefull 
> useful
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz 
> informations information
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz 
> informations information
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz completly 
> completely
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz allows to 
> allows one to
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz managment 
> management
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz overriden 
> overridden
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz splitted 
> split
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz splitted 
> split
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz managment 
> management
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz allow to 
> allow one to
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz allows to 
> allows one to
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz commited 
> committed
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz managment 
> management
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz dont don't
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz splitted 
> split
> I: circus: spelling-error-in-manpage usr/share/man/man1/circus.1.gz allows to 
> allows one to
> P: circus: example-shell-script-fails-syntax-check 
> usr/share/doc/circus/examples/test.sh
> 

All these problems should be fixed now (I have just dput a new version of the 
package) but the spellings 
in the man pages, for which I'll have to send a patch on the upstream branch. 
So I'll wait 
for the next upstream release to fix these.

David
 


-- 

David DOUARD             LOGILAB
Directeur du département Outils & Systèmes

+33 1 45 32 03 12        david.dou...@logilab.fr
+33 1 83 64 25 26        http://www.logilab.fr/id/david.douard

Formations - http://www.logilab.fr/formations
Développements - http://www.logilab.fr/services
Gestion de connaissances - http://www.cubicweb.org/

<<attachment: david_douard.vcf>>

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to