Hi again,
Am 2015-04-20 11:55, schrieb Jonas MEURER:
The bug can be fixed by renaming the 'reload' function to
'force-reload'
and dropping the original 'force-reload' alias for 'restart'. Please
note,
that fixing the 'Usage:' line by dropping 'reload' from the list of
supported actions is important as well. Otherwise, systemd tools try to
invoke 'reload' even if 'force-reload' is given as argument.
in some further discussion on IRC channel #debian-systemd, Michael Biebl
made me aware that my fix was not policy-compliant. According to Debian
Policy, 'force-reload' should reload the service if this function is
available, and restart otherwise. Therefore I reverted the change to add
a separate 'force-reload' action and kept 'force-reload' as an alias to
'restart'. Only the 'reload' option was dropped.
Additionally, I added a line at the beginning of the initscript,
sourcing
'/lib/lsb/init-functions'. This is necessary to make systemd aware of
status changes to the daemon that have been caused by running the
initscript directly (i.e. not through systemd helper tools). This change
is really non-intrusive and leads to a much better user experience.
See the attached patch for a proper fix.
I attached an updated patch.
I consider this bug as release-critical for Jessie, as it renders
smmstools unusable on Jessie installations whenever logrotate is
installed. Thus I suggest to push the fix into Jessie within the next
days. I'll gladly do an NMU if the maintainer(s) don't have the time
to push this fix into Jessie in time.
According to release managers, this update won't make it into Jessie,
which is already in the quiet period (shortly before release). Instead,
a fixed package should be uploaded to stable-proposed-updates in order
to make it into the first point release of Jessie (8.1).
If nobody speaks up, then I intend to upload the NMU to unstable next
week, wait one or two weeks and upload to stable-proposed-updates
afterwards.
Cheers,
jonas
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
