Am 21.04.2015 um 15:15 schrieb Jonas Meurer:
>> I consider this bug as release-critical for Jessie, as it renders
>> smmstools unusable on Jessie installations whenever logrotate is
>> installed. Thus I suggest to push the fix into Jessie within the next
>> days. I'll gladly do an NMU if the maintainer(s) don't have the time
>> to push this fix into Jessie in time.
>
> According to release managers, this update won't make it into Jessie,
> which is already in the quiet period (shortly before release). Instead,
> a fixed package should be uploaded to stable-proposed-updates in order
> to make it into the first point release of Jessie (8.1).
>
> If nobody speaks up, then I intend to upload the NMU to unstable next
> week, wait one or two weeks and upload to stable-proposed-updates
> afterwards.
I just uploaded the NMU to unstable now. You find the final NMU diff
attached to this mail. Only difference to my last patch is that the
changelog entry contains the number of this bugreport now.
I'll go ahead with an upload to stable-proposed-updates within the next
days.
Cheers,
jonas
diff -u smstools-3.1.15/debian/changelog smstools-3.1.15/debian/changelog
--- smstools-3.1.15/debian/changelog
+++ smstools-3.1.15/debian/changelog
@@ -1,3 +1,17 @@
+smstools (3.1.15-1.2) unstable; urgency=high
+
+ * NMU by Jonas Meurer to push the fix into Jessie.
+ * Fix initscript (debian/init.d):
+ * drop action 'reload' as it does not what policy demands it to do. Use
+ 'force-reload' in logrotate post-rotate action. This fixes 'force-reload'
+ action when used through systemd tools and prevents the smsd daemon
+ process from being killed at every log rotation. (closes: #782996)
+ * source /lib/lsb/init-functions in order to make systemd tools aware of
+ status changes to the daemon that have been caused by invoking the
+ initscript directly.
+
+ -- Jonas Meurer <m...@debian.org> Mon, 27 Apr 2015 20:45:40 +0200
+
smstools (3.1.15-1.1) unstable; urgency=low
* NMU - preventing smstools from entering jessie.
diff -u smstools-3.1.15/debian/init.d smstools-3.1.15/debian/init.d
--- smstools-3.1.15/debian/init.d
+++ smstools-3.1.15/debian/init.d
@@ -25,6 +25,8 @@
test -x $DAEMON || exit 0
+. /lib/lsb/init-functions
+
if [ ! -f /etc/default/$PACKAGE ]
then
exit 1
@@ -218,17 +220,6 @@
echo "$NAME."
;;
- reload)
- echo -n "Reloading $DESC: "
- status
- if [ "$?" = 0 ]; then
- stop restart
- start
- else
- echo "$NAME is not running."
- fi
-
- ;;
restart|force-reload)
echo -n "Restarting $DESC: "
@@ -237,7 +228,7 @@
;;
*)
- echo "Usage: /etc/init.d/$NAME {start|stop|force-stop|reload|force-reload|restart|status}"
+ echo "Usage: /etc/init.d/$NAME {start|stop|force-stop|force-reload|restart|status}"
exit 3
;;
esac
diff -u smstools-3.1.15/debian/logrotate smstools-3.1.15/debian/logrotate
--- smstools-3.1.15/debian/logrotate
+++ smstools-3.1.15/debian/logrotate
@@ -5,5 +5,5 @@
missingok
postrotate
- invoke-rc.d smstools reload > /dev/null
+ invoke-rc.d smstools force-reload > /dev/null
endscript
}
