Control: tags -1 patch
Hi,
On Tue, Nov 25, 2014 at 10:38:44PM +0100, Lucas Nussbaum wrote:
> Note that the build now fails on i386 too.
>
> Trying to reproduce it locally, I run into yet another problem:
>
> 1) Failure:
> repo::iterator::fs_preserves_error
> [/tmp/libgit2-0.21.1/tests/repo/iterator.c:952]
> Expected function call to fail: git_iterator_advance(&e, i)
This problem is only occurs when running is root (the test chmods a file to
000 and checks if accessing it fails). It would probably be a good idea to add
another test to check if the test is running as root, and fail in that case
(because the tests assume they aren't).
The failure that happens on the i386 buildd is this one:
1) Failure:
clone::nonetwork::local_absolute_path
[/«PKGBUILDDIR»/tests/clone/nonetwork.c:91]
Function call failed: (git_clone(&g_repo, local_src, "./foo", &g_options))
error -1 - git_path_direach callback returned -1
I can reproduce this in my test environment on i386 and amd64. It only happens
when the builddir and /tmp are on different filesystems. It seems the local
clone tries to create a hard link, which fails across filesystems (the fact
that this happens without fallback is an error in itself, so the test actually
discovered a problem here). When setting the TMPDIR to a directory on the same
filesystem, the test doesn't hit this issue, and the build works fine.
It's unclear to me why this only happens on i386, but I suspect that the setup
of the buildd chroots isn't the same everywhere.
In any case, adding this patch fixes it in my environment. I can do an NMU if
necessary.
diff --git a/debian/rules b/debian/rules
index 0d82de1..75b792d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -36,6 +36,12 @@ override_dh_auto_install :
dh_auto_install --builddirectory=build-debian-release
dh_auto_install --builddirectory=build-debian-devel
+override_dh_auto_test :
+ mkdir -p build-debian-release/tmp
+ TMPDIR=$(PWD)/build-debian-release/tmp dh_auto_test
--builddirectory=build-debian-release
+ mkdir -p build-debian-devel/tmp
+ TMPDIR=$(PWD)/build-debian-devel/tmp dh_auto_test
--builddirectory=build-debian-devel
+
override_dh_strip:
dh_strip --dbg-package=libgit2-dbg
Cheers,
Ivo
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
