Control: tag -1 - patch Control: tag -1 + fixed-upstream On Wed, 03 Dec 2014 16:55:46 +0100, Jan wrote:
> > > I'll investigate, thanks again! > > Thanks! > OK, after some deeper reading and some testing, it really seems to help. Cool! > And by checking out these changes I realized a couple of places where > widgets are initialized without a parent, because they'll be added to a > layout later, _but_ in these places, adding them to a layout is > conditional. That's a sure leak right there ;) Right, I remember seeing one of those places, great that you found more :) > Also, setting the parent initially doesn't hurt, and makes it safer in > cases like these, so it's a good change. *nod* > The only issue I've seen is a certain label that shouldn't be visible in > certain situations but now, having always a parent, is. But that's one > of the leaks precisely because of that, so I'll be fixing this properly. Was this in the Comment() object? I've also seen some weirdness with lables there, that's why I used the delete's there. Of course fixing this properly is much better :) > I'll be merging these to master on a file-per-file basis for clarity, > and change a few things in the way. /me git pulls This looks great, thanks! > The BTS suggests that there's a patch that could be used for Dianara, > but I guess we're in agreement that these only applies correctly to > current master and can't be safely applied to v1.2.4 without further > changes. Yeah, totally. Let's update the tags :) > I'll be releasing 1.2.5 in about 2 weeks, but I guess that's out of the > question for Jessie. Right, jessie is too frozen. > (BTW, semi-offtopic, v1.2.4 still hasn't entered Testing due to freeze > block. Should I ping Mònica? =) I guess the chances are close to zero to get it into jessie. It was uploaded a few days too late to make it into testing before the freeze start on the 5th of November, and there are no serious or important bugs that would qualify for a freeze exception. Cf. https://release.debian.org/jessie/freeze_policy.html > Thanks a lot, again, for your patch, it was very helpful! Thanks to you for taking the time to go through my sketch of a patch and fix it up, and for your awesome speed in doing so! Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Tom Waits: Romeo Is Bleeding
signature.asc
Description: Digital Signature
