Hola! Thanks for investigating this! However...

On Tue, Dec 02, 2014 at 07:47:44PM +0100, gregor herrmann wrote:
> >   PID USER      PRI  NI  VIRT   RES   SHR S CPU% MEM%   TIME+  Command
> > 23560 gregoa     20   0 1738M 1055M 13332 S  0.0 27.4  0:16.46 dianara
> > 20806 gregoa     20   0 1268M  382M 58028 S  0.0 10.0 48:56.15 iceweasel
> 
> ¡Hola Mònica, hola Jan!
> 
> This looks better, doesn't it :)
> 
>   PID USER      PRI  NI  VIRT   RES   SHR S CPU% MEM%   TIME+  Command
> 31723 gregoa     20   0  556M 60748 19616 S  0.0  1.5 12:30.11 ./dianara
>  5789 gregoa     20   0 1752M  628M 44124 S  4.8 16.4  2h13:06 iceweasel
> 

It looks a lot better! 
Does this difference apply to similar usage, with same number of posts
per page, same update interval and running for a similar amount of time?
Even so, memory usage depends greatly on what's in the posts, of course.

But you also say that now the memory usage stays constant, so it sounds
very promising =)

> With the help of a friend and qtcreator's nice valgrind integration I
> created a patch which adds parents to some objects (so that they are
> auto-reaped) or manually deletes them.
> 
> No guarantees that all parts of the patch are necessary or correct
> but with it dianara is "valgrind clean" and the memory usage stays
> constant even after running for several days.
> 
> The patch applies against git HEAD as of now (d520e57); I hope it
> serves as a starting point to get the memory leaks fixed.
> 

I find it a little strange that it really fixes things, mainly because,
from what I've seen by giving it a quick look, the fixes are mostly
specifying the parents of several objects, and manually deleting others.

The reason those objects (at least, most of them) don't have a parent
set, is because they're re-parented when they're managed by a QLayout.
There's of course, the possibility of Qt bugs and that not being handled
correctly. The same applies to the manual deletion of some widgets in
Comment(); those are supposed to be properly deleted automatically when
the parent Comment() object is destroyed.

There are also a few objects which will live as long as the program does,
so those are not really a concern either way (tray icon, menus, qoauth
handler...).


I'll investigate, thanks again!

Cheers! o/


> 
> Cheers,
> gregor
> 
> -- 
>  .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
>  : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
>  `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
>    `-   


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to