Hi Dmitry,

On 2014-09-15 02:02, Dmitry Smirnov wrote:
On Mon, 15 Sep 2014 00:56:35 Filipus Klutiero wrote:
Thank you. Here are some more issues I notice:
"libteam" is a library for communication with kernel module (Netlink).|
The noun phrase "kernel module" is missing a determiner. Perhaps this should
read "with the Netlink kernel module".

Also, "libteam" should not be quoted.

This is already implemented in the Linux kernel by the bonding driver but

   unlike the bonding driver, libteam (user space) have the following
   additional features|
"libteam" is third person singular, therefore "have" should read "has".
Updated with our 5th correction of the long description:

http://anonscm.debian.org/cgit/collab-maint/libteam.git/commit/?id=00659711ac9ef2e69d0825dfe947a2ea4c469eb6

Thanks again for all your suggestions.


Thanks again for the changes.

Here is libteamdctl0's description with more suggestions:
|
"libteamdctl" is a library for communication with teamd process
  (via D-Bus, unix socket or zeromq).|

|"libteamdctl" should not be quoted.
"unix" is a proper name and should be capitalized.

|
|
  It is used by `teamdctl` utility.|

The noun phrase "`teamdctl` utility||" is missing a determiner. This should read "|the 
|`teamdctl` utility||", or just "`teamdctl`||".

|
  .
  Libteam provides a mechanism to team multiple NICs (ports) at OSI Layer 2
  (Data link) into a single virtual NIC. The process is called "channel
  bonding", "Ethernet bonding", "channel teaming", "link aggregation", etc.
  This is already implemented in the Linux kernel by the bonding driver but
  unlike the bonding driver, libteam (user space) has the following
  additional features:|

|"unlike [...] additional"| has something redundant. I'm not sure what libteam 
is and whether is uses the bonding driver or whether it replaces it, but if it 
supplements it, I would suggest the following formulation:

The user-space libteam library adds the following features to the basic 
capabilities already implemented in the Linux kernel's bonding driver:

|
   * load-balancing for LACP support
   * NS/NA (IPV6) link monitoring
   * port priorities and stickiness ("primary" option enhancement)
   * separate per-port link monitoring setup
  .
  Libteam requires Linux kernel 3.3 or higher.|

The noun phrase "Linux kernel 3.3 or higher||"||" is missing a determiner. This could read 
"version 3.3 or higher of the Linux kernel", or just "Linux 3.3 or higher", although I'm not 
sure this sentence is necessary at this point.

--
Filipus Klutiero
http://www.philippecloutier.com

Reply via email to