tags 341125 patch
thanks

Florian Ernst wrote:

To be honest, I just kept bogomips for the upload when adopting the
package, and now I'm searching for a legitimate reason to keep it once
the package will be split up as proposed in #253302, as a simple
| $ cat /proc/cpuinfo
should suffice as a substitute...

Most probably the bogomips utility will disappear in the near future.

Yes, the BogoMips mini-Howto also recommends `cat /proc/cpuinfo' if
that is available, so Linux users would not miss the bogomips utility.
Nevertheless, I was curious and investigated the issue.

I downloaded the sysutils source package, read the source code for
bogomips, and the explanation for the unusual return value is rather
simple. The upstream author simply forgot to return or exit() from his
main() function. Of course, "gcc -Wall" warns about this, but the
warnings are turned off in the Makefile...

The following patch solves the problem:

-------------------------------<-8-----------------
diff -u bogomips.c~ bogomips.c
--- bogomips.c~ 2001-12-02 22:07:56.000000000 +0100
+++ bogomips.c  2005-11-28 19:36:31.000000000 +0100
@@ -62,4 +62,5 @@
                while(1) {calibrate_delay();}
        }
         calibrate_delay();
+       return 0;
 }
-------------------------------<-8-----------------


Thank you for adapting the sysutils package. BTW, you probably want to
remove the files tofrodos-1.7.6/{from,to}dos.exe from the orig.tar.gz
file.

--
 Sven Joachim







--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to