Hi KiBi,
On Thu, Nov 28, 2013 at 10:50:47AM +0100, Cyril Brulebois wrote:
> Control: tag -1 confirmed
>
> Salvatore Bonaccorso <car...@debian.org> (2013-11-28):
> > The corresponding bug for libnet-server-perl is at [1].
> >
> > [1] http://bugs.debian.org/693320
> >
> > This was fixed in libnet-server-perl/2.007-1 for testing and unstable
> > already.
> >
> > Could you accept the attached patch for wheezy-proposed-updates?
>
> Looks good to me. You could maybe reference munin in the changelog, so
> that munin users know they want that fix?
Thanks for the quick response, attached the new debdiff mentioning the
problem with munin-node. Can I go ahead with the upload?
> (Not planning to address the $peeraddr bit at some point?)
Yes sure, can go also addressing that. But I would prefer to have the
fix integrated upstream first, and in unstable (altough it is trivial
to check first if value is defined ...; is this fine with you? Once
this is done for unstable, I then could open a new pu request).
Regards,
Salvatore
diff -Nru libnet-server-perl-2.006/debian/changelog
libnet-server-perl-2.006/debian/changelog
--- libnet-server-perl-2.006/debian/changelog 2012-06-25 15:46:18.000000000
+0200
+++ libnet-server-perl-2.006/debian/changelog 2013-11-28 12:32:23.000000000
+0100
@@ -1,3 +1,14 @@
+libnet-server-perl (2.006-1+deb7u1) wheezy; urgency=low
+
+ * Team upload.
+ * Add fix-use-of-uninitialized-value-in-pattern-match.patch.
+ Fixes use of uninitialized value in pattern match.
+ This in particular affects munin-nodes under wheezy. Logs are spammed
+ with entries: "Use of uninitialized value in pattern match (m//) at
+ /usr/share/perl5/Net/Server.pm line 600.". (Closes: #693320)
+
+ -- Salvatore Bonaccorso <car...@debian.org> Thu, 28 Nov 2013 12:31:37 +0100
+
libnet-server-perl (2.006-1) unstable; urgency=low
* Imported Upstream version 2.006
diff -Nru
libnet-server-perl-2.006/debian/patches/fix-use-of-uninitialized-value-in-pattern-match.patch
libnet-server-perl-2.006/debian/patches/fix-use-of-uninitialized-value-in-pattern-match.patch
---
libnet-server-perl-2.006/debian/patches/fix-use-of-uninitialized-value-in-pattern-match.patch
1970-01-01 01:00:00.000000000 +0100
+++
libnet-server-perl-2.006/debian/patches/fix-use-of-uninitialized-value-in-pattern-match.patch
2013-11-28 12:32:23.000000000 +0100
@@ -0,0 +1,31 @@
+Description: Fix of uninitialized value in pattern match
+Origin: upstream,
https://metacpan.org/diff/release/RHANDOM/Net-Server-2.006/RHANDOM/Net-Server-2.007
+Bug: https://rt.cpan.org/Public/Bug/Display.html?id=78828
+Bug-Debian: http://bugs.debian.org/693320
+Forwarded: https://rt.cpan.org/Public/Bug/Display.html?id=78828
+Author: Salvatore Bonaccorso <car...@debian.org>
+Last-Update: 2013-11-28
+Applied-Upstream: 2.007
+
+--- a/lib/Net/Server.pm
++++ b/lib/Net/Server.pm
+@@ -587,7 +587,8 @@
+
+ # if the addr or host matches a deny, reject it immediately
+ foreach (@{ $prop->{'deny'} }) {
+- return 0 if $prop->{'peerhost'} =~ /^$_$/ && defined
$prop->{'reverse_lookups'};
++ return 0 if $prop->{'reverse_lookups'}
++ && defined($prop->{'peerhost'}) && $prop->{'peerhost'} =~ /^$_$/;
+ return 0 if $peeraddr =~ /^$_$/;
+ }
+ if (@{ $prop->{'cidr_deny'} }) {
+@@ -597,7 +598,8 @@
+
+ # if the addr or host isn't blocked yet, allow it if it is allowed
+ foreach (@{ $prop->{'allow'} }) {
+- return 1 if $prop->{'peerhost'} =~ /^$_$/ && defined
$prop->{'reverse_lookups'};
++ return 1 if $prop->{'reverse_lookups'}
++ && defined($prop->{'peerhost'}) && $prop->{'peerhost'} =~ /^$_$/;
+ return 1 if $peeraddr =~ /^$_$/;
+ }
+ if (@{ $prop->{'cidr_allow'} }) {
diff -Nru libnet-server-perl-2.006/debian/patches/series
libnet-server-perl-2.006/debian/patches/series
--- libnet-server-perl-2.006/debian/patches/series 2012-06-25
15:46:18.000000000 +0200
+++ libnet-server-perl-2.006/debian/patches/series 2013-11-28
12:32:23.000000000 +0100
@@ -1 +1,2 @@
0001-Fix-errors-in-POD.patch
+fix-use-of-uninitialized-value-in-pattern-match.patch
