On Mon, Nov 18, 2013 at 09:39:24AM -0500, Yaroslav Halchenko wrote: > Thanks for checking on this! the patching is done at the > neurodebian-popularity-contest postinst time > > https://github.com/neurodebian/neurodebian/blob/5dd6c9f932a2b07412488d62dad2b700054d0903/debian/neurodebian-popularity-contest.postinst > > so checking/patching also a cron file although possible, might be a bit too > much of a hack...
Indeed, patching conffiles at install time is a big no-no. > could this change be done "upstream" in stock > popularity-contest in Debian? Then I will similarly patch > /etc/popularity-contest.conf for the variables. > > Looking forward though -- imho it would be nice if the > /etc/popularity-contest.conf had at the end smth like > > if [ -d /etc/popularity-contest.d ]; then > for i in /etc/popularity-contest.d/*.conf; do > if [ -r $i ]; then > . $i > fi > done > unset i > fi > > so we could avoid patching at all and just provide > /etc/popularity-contest.d/neurodebian.conf which would extend the necessary > variables? The problem is that the result depends in which order the "for" loop read the file, since they all set the same variables, unless one do in all the *.conf like SUBMITURLS="$SUBMITURLS http://myurl"; so this is not very robust. Cheers, -- Bill. <ballo...@debian.org> Imagine a large red swirl here. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
