-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I managed to my own question in the end regarding DESTDIR, thanks to the following post on the list http://lists.debian.org/debian-mentors/2011/03/msg00127.html
So I have updated the vpcs package on mentors, to use this new information. I have also fixed the items pointed out to me by Juhani. As usual the package is on: http://mentors.debian.net/package/vpcs Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/v/vpcs/vpcs_0.5b0-1.dsc Regards Daniel Lintott On 26/09/13 21:34, Daniel Lintott wrote: > On 26/09/13 19:19, Juhani Numminen wrote: >> Hello, Daniel, > >> Here’s my review of vpcs 0.5b0-1. I’m not a DD, so I can’t >> upload. > >> Because this package hasn’t been in Debian, the d/changelog >> entries should merged. > > Okay, I shall merge the two entries. > >> Your d/rules isn’t a ”sample debian/rules” anymore and those >> comment can be removed. Also, the ”commands to install the >> package into debian/vpcs/usr” have been already added as far as I >> can see :) > > Oddly, I thought about removing the comments... But didn't, I > shall remove them for the next upload. > > With regards to the DESTDIR, I'm hitting a stumbling block. It got > me thinking that I shouldn't need to manually override > dh_auto_install, so have removed that. > > pbuilder calls make with > DESTDIR=/tmp/buildd/vpcs-0.5b0/debian/vpcs, which wipes out the > current DESTDIR?=/usr or DESTDIR+=/usr > > Is it then okay to change the install lines of the Makefile to > include the /usr directory? > > Example: install vpcs$(BIN_EXT) $(DESTDIR)/usr/bin/ > >> In d/control: this is a minor thing, Build-Depends: debhelper (>= >> 9.0.0) could also be (> 9). > > Will be changed in the next upload. > >> Have you sent your patches to upstream consideration? At least >> you should probably send the ManpageFix. > > I have sent the patches from the previous version upstream. The > manpage was patched, but when it was edited new errors were > introduced. > > The two makefile patches, are more difficult to integrate upstream > as the author builds using BSD-Make as opposed to GNU-Make. > > Regards, > > Daniel Lintott > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJSRXGGAAoJEMw/9yOWzAkJeeUH+gP1H0znB+PHJ/f9lcFwNEmj Xppe7LqkHBCh5Grz+xPFCyqMWFYi3iDWw5rnru4htzSxjk64i1v49HkGzVzZ86UJ OuY2G6tZew5UIhI3NfnxZFT6nPNu4hjyOyGPMT+E2vy3fLTDXuEikU0Uhyw5jE6f rdHtH8z9G8JJHCeNHC4moKBzEhfP/zTt7q6gs3jBGbwQuExuolRIkrvBx6NbqbqR harWRET7Cud6ITqx541LiYGz9teIrjvejPIx1h633IttCj9a30dKkHw4/cPr4J4j kPGnCAhTVrtt3Dvu1vpKXrjoxFXkL2vKT6hyXxlkhvMHSukOrSycOSqbl9bFvIE= =8dyq -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
