-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 26/09/13 19:19, Juhani Numminen wrote: > Hello, Daniel, > > Here’s my review of vpcs 0.5b0-1. I’m not a DD, so I can’t upload. > > Because this package hasn’t been in Debian, the d/changelog > entries should merged.
Okay, I shall merge the two entries. > Your d/rules isn’t a ”sample debian/rules” anymore and those > comment can be removed. Also, the ”commands to install the package > into debian/vpcs/usr” have been already added as far as I can see > :) Oddly, I thought about removing the comments... But didn't, I shall remove them for the next upload. With regards to the DESTDIR, I'm hitting a stumbling block. It got me thinking that I shouldn't need to manually override dh_auto_install, so have removed that. pbuilder calls make with DESTDIR=/tmp/buildd/vpcs-0.5b0/debian/vpcs, which wipes out the current DESTDIR?=/usr or DESTDIR+=/usr Is it then okay to change the install lines of the Makefile to include the /usr directory? Example: install vpcs$(BIN_EXT) $(DESTDIR)/usr/bin/ > In d/control: this is a minor thing, Build-Depends: debhelper (>= > 9.0.0) could also be (> 9). Will be changed in the next upload. > Have you sent your patches to upstream consideration? At least you > should probably send the ManpageFix. I have sent the patches from the previous version upstream. The manpage was patched, but when it was edited new errors were introduced. The two makefile patches, are more difficult to integrate upstream as the author builds using BSD-Make as opposed to GNU-Make. Regards, Daniel Lintott -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJSRJpvAAoJEMw/9yOWzAkJCJAH/iCKJbhddXj7NOmdvhIOLgDV zMIgF86LHmkPuxPqdD/khSrrxeX28uRHXO0tqpZRUiv9JVLqnl6O+n8z8C62y45q nq3h41UWPckRKeHWFDO5H8u4amZJKPMNpERgWYJkPKdhq4IhP3nrIZpjEdNyKlO5 ptKZLJMT62/NBoSIAW8ZF7jVW/DEgFZkvaAMIykrIR3F4JvCYHLNU9RVyx2tcgBJ ehH0pJPHf+1hQ2TmcDRMckjckWmR+/YmLVuUmXpEEieGQ5Fnu10t0v+WKBwQ+teX jYKK2I8G/v3tXt/9TAsM/xn0oyJC7k/ucKfcm4TSIU0OonGI4T5JnNiCABqEsio= =DSzt -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
