On 07/16/2013 11:38 PM, Adrian Bunk wrote:
On Tue, Jul 16, 2013 at 04:45:03PM +0200, Paul Gevers wrote:
I am also no GNOME user. But lets look at the Debian policy [1]. (below).
To me it says that suggests is very reasonable if liferea works with
only red crosses at the location of the icons, which seems to be the
case. Depends is definitely overkill. I could be persuaded to believe
that recommends is good enough, but you have to give better arguments
than merely some red crosses.
...
Depends is definitely required.
After an "apt-get install <package>" a user can expect a package to work
correctly, even when recommended packages are not installed by default.
Just going through the source code in the latest release, it seems to me
that liferea gets icons from three locations.
1. Most of Liferea's core icons come from GTK_STOCK (ie:
GTK_STOCK_REFRESH). Especially the ICONS related to the functionality
of the program (Toolbar: New subscription, Mark Items Read, Back,
Forward, Next Unread Item, Update All, Search All Feeds, etc.)
2. Some (4-5?) of Liferea's icons come from the GNOME theme that you're
using. The key thing is, if it doesn't exist in the GNOME theme that
you're using, you'll get a warning in the console and it will just use a
generic GTK_STOCK icon instead. So it's not actually required that you
have a gnome icon theme.
3. The rest of Liferea's icons are bundled with the package in /pixmaps.
You don't get the blank / red "X" buttons in liferea that you get in
epiphany-browser because of the GTK_STOCK icon fallback code in liferea
(tested and works for me!). So it's a completely different situation.
Consider that a depends on gnome-icon-theme is added, then liferea isn't
going to be installable unless the default gnome-icon-theme is
installed. This doesn't make any sense as some people might want to use
gnome-icon-theme-nuovo or gnome-icon-theme-suede or
gnome-icon-theme-yasis or gnome-icon-theme-gartoon instead which do
*NOT* provide gnome-icon-theme.
Using these alternative gnome themes without the default
gnome-icon-theme would make liferea uninstallable, if a depends on
gnome-icon-theme is added, even though liferea would work just fine :(
So then when looking at a recommends on gnome-icon-theme, it only makes
sense to add it if the functionality of liferea is enhanced by using the
gnome-icon-theme. Since the fallback to GTK_STOCK icons seems to be
working for me when you don't have a gnome-icon-theme, I just can't see
how liferea is really enhanced by using gnome-icon-theme.
Then finally... Liferea is *NOT* showing you the wrong icons if you
don't have gnome-icon-theme installed. Rather, it's just using the
GTK_STOCK icons instead of gnome theme icons. This appears to be
intentional / planned by upstream.
So "Suggests" on any of the gnome-icon-themes does seem to be the best
way to go here. Mainly because liferea does a fallback to GTK_STOCK
icons which seems to work just fine.
But anyway, this isn't my decision to make. Just my 2 cents.
-David
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
