On Sun, Oct 23, 2005 at 05:54:18PM -0500, minghua wrote: > Okay, so this is a patch for adding im-switch support to scim-pinyin by > Emfox Zhou. The patch is against SVN trunk.
Now a few comments about this patch. First, the conffile issue. Now /etc/X11/xinit/xinput.d/scim-pinyin is a conffile, how to deal with it later if we decide to give the user the choice of choosing between scim and xim for $GTK_IM_MODULE? I really want to do this because I prefer GTK_IM_MODULE="xim" myself, and I do plan to add this feature soon, by a debconf question. If we apply this patch before the debconf stuff is in place, GTK_IM_MODULE will be hardcoded, and since im-switch is not really very flexible (see the second comment below), it's hard for the user to change this. Also when we eventually switch to debconf, we need all kinds of tests to deal with the old conffiles. Second, as I've said in scim-user mailing list, im-switch breaks the setting in ~/.gnomerc. $XMODIFIERS and $GTK_IM_MODULE get overriden as long as im-switch is installed, even if the user doesn't want to use im-switch at all (im-switch set to none). And as im-switch classify by locale, the current patch means en_US.UTF-8 locale users have no way to get scim-pinyin working except removing im-switch. This is very bad, as one very good point for scim is its friendliness to non-native speakers. If scim-pinyin enforces a zh_CN locale, and breaks previously working configurations in ~/.gnomerc, I'm not going to let it happen. So this patch still need a lot of work, but it's a very good start. Thanks for the work, Emfox. Ming 2005.10.23 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
