2005/10/24, Ming Hua <[EMAIL PROTECTED]>: > On Sun, Oct 23, 2005 at 05:54:18PM -0500, minghua wrote: > > Okay, so this is a patch for adding im-switch support to scim-pinyin by > > Emfox Zhou. The patch is against SVN trunk.
sorry for the inconvenience taken to you of not working using the BTS system, that's because i am only not familiar with it, and i will try to improve it. > > Now a few comments about this patch. > > First, the conffile issue. Now /etc/X11/xinit/xinput.d/scim-pinyin is a > conffile, how to deal with it later if we decide to give the user the > choice of choosing between scim and xim for $GTK_IM_MODULE? I really > want to do this because I prefer GTK_IM_MODULE="xim" myself, and I do > plan to add this feature soon, by a debconf question. If we apply this > patch before the debconf stuff is in place, GTK_IM_MODULE will be > hardcoded, and since im-switch is not really very flexible (see the > second comment below), it's hard for the user to change this. Also when > we eventually switch to debconf, we need all kinds of tests to deal with > the old conffiles. yes, im-switch is not flexible. here is an example way from kinput, that is, after installed, there will be these file in /xinput.d: kinput2-canna kinput2-canna_canna kinput2-canna-wnn_canna kinput2-canna-wnn_wnn i think it may be useful probably to have different config files like "scim-pinyin_xim" "scim-pinyin_scim", and thus im-switch itself could switch between them and no need to interactive with silly debconf. > > Second, as I've said in scim-user mailing list, im-switch breaks the > setting in ~/.gnomerc. $XMODIFIERS and $GTK_IM_MODULE get overriden as > long as im-switch is installed, even if the user doesn't want to use > im-switch at all (im-switch set to none). And as im-switch classify by > locale, the current patch means en_US.UTF-8 locale users have no way to > get scim-pinyin working except removing im-switch. This is very bad, as > one very good point for scim is its friendliness to non-native speakers. > If scim-pinyin enforces a zh_CN locale, and breaks previously working > configurations in ~/.gnomerc, I'm not going to let it happen. > i'd think it's a normal bug of im-switch, with the lines in file /etc/X11/Xsession.d/90im-switch: for f in $HOME/.xinput.d/${lang_region} \ $HOME/.xinput.d/default \ /etc/X11/xinit/xinput.d/${lang_region} \ /etc/X11/xinit/xinput.d/default ; do [ -r $f ] && . $f && break done hey, so you see the two lines start with "/etc/X11..." should be get rid of, or at least should be optional. i think i may file a bug against it first, and started to work at changing the default way. > So this patch still need a lot of work, but it's a very good start. > Thanks for the work, Emfox. > > Ming > 2005.10.23 > -- GnuPG Public Key: 0xF7142EC2