On 03/09/2013 02:57 AM, Michael Tokarev wrote: > It does not matter anymore since 3.4 kernel and all previous 3.x stable > series as well, since upstream commit 64f371bc3107e69efce563a3d0f0e6880de0d537 > which has been accepted to all stable releases. > > This is what fixed the root cause and basically made the size of the packet > irrelevant as long as it is the same or larger in the kernel.
I see, but nevertheless I'm now surprised. If it's true what you say, then parisc64 (64bit 3.8.x kernel) should have worked out of the box. But it didn't. 32bit kernel with 32bit userspace worked. 64bit kernel (which had previous to my patch larger structs due to "unsigned long" vs. "unsigned int" and in addition the 64bit alignment problem) was broken. > Whole if..arch, whole this function and adopting struct size difference > are not needed anymore in userspace and can be removed from automountd, > Ian kept these "for documentation and historical reasons" and in order > to not break stuff with old (before that commit) kernel. Sure, I don't like this if..arch stuff either. > As Ian replied to your patch on autofs mailinglist, this is only needed for > old kernels, but he applies your patch anyway. I'd go for removing whole > hack entirely, maybe after a bit more waiting (say, when all major > distributions > will move on to the fixed kernel already), because whole thing is just > disgusting and hurt eyes. This hack, with or without your change, is > definitely not needed on Debian. > And if there is, it must be something else, because since the above mentioned > commit, it all Just Works, and if there's a problem it is elsewhere. I'll check and try to dig deeper again next week when I'm back from vacation.. Helge -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
