Package: isdnlog
Version: 1:3.25+dfsg1-3wheezy1
Severity: important
Tags: patch

Dear Maintainer,

the following line in isdnvboxserver.postinst

| if [ -z "$RET" -o `echo "$RET" | tr A-Z a-z` = quit ]; then # do it by hand

will fail horribly and did so for me (aborting configure) thus
constantly driving into configure again if $RET is empty. And the code
suggests this is a value postinst has to deal with. The reason is the
`...` will expand to an empty string, causing failure on both bash and
dash:

$ bash -c 'RET= ; [ -z "$RET" -o `echo "$RET" | tr A-Z a-z` = quit ]'
bash: line 0: [: too many arguments
$ dash -c 'RET= ; [ -z "$RET" -o `echo "$RET" | tr A-Z a-z` = quit ]'
dash: 1: [: =: unexpected operator
$

Quick workaround, protect the `...` output.

| if [ -z "$RET" -o "`echo "$RET" | tr A-Z a-z`" = quit ]; then # do it by hand

Post-wheezy, all maintainer scripts should be checked for fragile
coding, there are probably several more places that might create
havoc.

    Christoph

Attachment: signature.asc
Description: Digital signature

Reply via email to