Package: texmacs
Version: 1:1.0.7.16-1
Severity: serious
Tags: patch
Justification: fails to build from source (but built successfully in the past)
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu raring ubuntu-patch



In Ubuntu, the attached patch was applied to achieve the following:

  * Make debian/fixsh operate on debian/texmacs instead of debian/tmp,
    and move it to binary-post-install/texmacs:: to keep consistency
    when not building arch-indep packages, as on the Dbeian buildds.
  * Remove maxima_filter in clean to fix FTBFS on on non-i386 arches.

So, there are three distinct bugs here, only two of which I address
with this patch:

1) When building without arch-indep (dpkg-buildpackage -B, instead of
   dpkg-buildpackage -b), debian/fixsh doesn't trigger.  The top
   changelog entry addresses that and fixes cross-arch consistency.

2) You're trying to ship an i386 binary on all arches, which causes
   an FTBFS (quite rightly so), the clean addition fixes that, BUT:

3) The i386 binary in question is a binary compiled from sources
   that no longer ship (the maxima_filter sources and Makefile were
   removed upstream, but they left the binary cruft in their tarball,
   it looks like).  Either you should repack your source as a dfsg
   orig tarball (as shipping a binary without source doesn't meet the
   DFSG), or you should talk your upstream into dropping the stray
   binary and re-releasing a 1.0.7.16.0 or something, so you can
   package that instead.

... Adam

-- System Information:
Debian Release: wheezy/sid
  APT prefers raring-updates
  APT policy: (500, 'raring-updates'), (500, 'raring-security'), (500, 'raring')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.8.0-0-generic (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -u texmacs-1.0.7.16/debian/rules texmacs-1.0.7.16/debian/rules
--- texmacs-1.0.7.16/debian/rules
+++ texmacs-1.0.7.16/debian/rules
@@ -24,6 +24,7 @@
 	rm -rf TeXmacs/misc/pixmacs/.xvpics
 	rm -f config.log misc/admin/admin.makefile
 	rm -f packages/macos/Base.xcconfig
+	rm -f plugins/maxima/bin/maxima_filter
 
 binary-post-install/texmacs-common::
 	mv debian/texmacs-common/usr/share/texmacs/TeXmacs/misc/pixmaps debian/texmacs-common/usr/share/pixmaps/texmacs
@@ -49,3 +50,5 @@
+binary-post-install/texmacs::
+	sh ./debian/fixsh
+
 binary-predeb/texmacs-common::
 	chmod a+x debian/texmacs-common/usr/share/texmacs/TeXmacs/langs/encoding/*.awk
-	sh ./debian/fixsh
diff -u texmacs-1.0.7.16/debian/changelog texmacs-1.0.7.16/debian/changelog
diff -u texmacs-1.0.7.16/debian/fixsh texmacs-1.0.7.16/debian/fixsh
--- texmacs-1.0.7.16/debian/fixsh
+++ texmacs-1.0.7.16/debian/fixsh
@@ -2,7 +2,7 @@
 set -x
 
 # BIN are lists of ELF binaries and Perl/Python scripts so should be omitted.
-PLGIN=debian/tmp/usr/lib/texmacs/TeXmacs/bin
+PLGIN=debian/texmacs/usr/lib/texmacs/TeXmacs/bin
 BIN="maxima_filter realpath tm_axiom tm_graphviz tm_maple_5 tm_r tm_shell bbox_add.pl perl-tm_asy realpath.py tm_asy2 tm_mupad tm_python tm_sage"
 
 cd $PLGIN

Reply via email to