Michael Stapelberg wrote:
> I talked to mbiebl and Mithrandir about it and we’ve come to the
> conclusion that we want to ship the files in /lib instead (for
> consistency with upstream packages and other distributions) and maybe
> work on UCF support for this location instead of shipping the service
> files in /etc.
> 
> I have updated the patch and attached the new version.

This is applied. However, I wonder about this part of it:

> --- a/autoscripts/postinst-init
> +++ b/autoscripts/postinst-init
> @@ -1,4 +1,10 @@
>  if [ -x "/etc/init.d/#SCRIPT#" ]; then
> +     # In case this system is running systemd, we need to ensure that all
> +     # necessary tmpfiles (if any) are created before starting.
> +     if [ -d /sys/fs/cgroup/systemd ] ; then
> +             systemd-tmpfiles --create >/dev/null || true
> +     fi
> +
>       update-rc.d #SCRIPT# #INITPARMS# >/dev/null
>       invoke-rc.d #SCRIPT# start || #ERROR_HANDLER#

This is a lot of boilerplate to add to every init script in Debian.

Is there any reason to add this to packages that have no systemd tmpfiles?

> diff --git a/autoscripts/postrm-init b/autoscripts/postrm-init
> index 1c29298..61dcfc5 100644
> --- a/autoscripts/postrm-init
> +++ b/autoscripts/postrm-init
> @@ -1,3 +1,10 @@
>  if [ "$1" = "purge" ] ; then
>       update-rc.d #SCRIPT# remove >/dev/null
>  fi
> +
> +
> +# In case this system is running systemd, we make systemd reload the unit 
> files
> +# to pick up changes.
> +if [ -d /sys/fs/cgroup/systemd ] ; then
> +     systemctl --system daemon-reload >/dev/null || true
> +fi

I'm a bit surprised this is necessary. Is this package removal case
currently broken when using systemd with all the packages out there that
don't do this?

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature

Reply via email to