On Tue, 2012-05-29 at 13:44:13 -0500, Jonathan Nieder wrote: > Guillem Jover wrote: > > On Sat, 2012-05-26 at 16:03:01 -0500, Jonathan Nieder wrote: > > >> dh_builddeb -- -Zgzip -z9 > >> dpkg-deb: building package `btrfs-tools' in > >> `../btrfs-tools_0.19+20120328-1_amd64.deb'. > >> dpkg-deb: building package `btrfs-tools-dbg' in > >> `../btrfs-tools-dbg_0.19+20120328-1_amd64.deb'. > >> dpkg-deb: error: invalid compressor parameters: unknown compression > >> strategy > >> [...] > >> dh_builddeb: dpkg-deb -z1 -Zxz -Sextreme -Zgzip -z9 --build > >> debian/btrfs-tools-udeb ../btrfs-tools-udeb_0.19+20120328-1_amd64.udeb > >> returned exit code 2 > [...] > > I've started reworking a bit the strategy logic, for starters I'm > > adding a "none" strategy so that it can be reset explicitly. > > Please feel free to close this bug with that change.
Ok, perfect. > [...] > > Yeah, I'm not very thrilled with the behaviour changing depending on > > the relative order of the -Z and -S options. Same options being > > overridden by later instances seems fine though. I'll think about what > > else might be feasible to do for a bit. > > It might make sense to make the meaning of strategies not specific to > each compression type, so using -Sextreme with -Zgzip would be a no-op > instead of an error. But I don't think that's urgent --- it just > sounds like something fun to do if I get (or some other interested > person gets) a spare moment. Yeah, one part of that rework went into that direction, making the strategies global, so that dpkg-deb can know immediately when setting them which ones are valid, and a later check verifies that they are valid for the specific compressor. I'm not sure we should allow specifying the wrong strategy for a compressor as that might cause the caller to not notice the mistake. thanks, guillem -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
