-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi Niels
On 23/05/12 07:27, Niels Thykier wrote: > However, I must admit I am a bit concerned in the use of of "!=" > with reals (floats/doubles)[0]. To my understanding (in at least > C/C++) that is very likely to always be true due to even minor > rounding errors[1]. Presumably this is why upstream used > "Math.round" in the first place. It is possible that it only apply > to expressions (and not stored values in variables) or Java handles > this better, but in this case, I believe a comment in the code > documenting this assertion would be prudent. I had the same concern when writing this patch but reading into this in a bit more detail I decided that this was actually OK for the following reason. The priority (see [0]) is always one of four values: -0.25 0.5 0.0 -0.5 I did a quick check and all four of these values can be represented accurately in Java (this is not true of all float/double literals). I'll update the patch with an appropriate comment to this effect. Cheers James [0] http://www.w3.org/TR/xslt11/#conflict - -- James Page Ubuntu Core Developer -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJPvJ2lAAoJEL/srsug59jDGIoP/jLm1923bfy2YujGzeoD9Ap9 Wb2N6ZSI/bRqGTrz2zo533RN2BeVPsPZknj1g/0VqT42pAEgwWafzLBow8w7KafV X3Wvio6IMdlhbASQo+iYxlXaFlykHH+UVhWYJfcrRuiCIaCDTGJfTE/Hct7ReGa/ ydk8k95kg7sGmZWXCRc4Rb+ctz48Va1a7mWiCMRGBMREkJs5oLV9FQUVSIEnwp// zMgQ274PD736HfkkwfOSNDdnarW2rVo1+19Lf3eONNznxJm2L67BHYkDPPx5d895 979JLO+R1gYFSdrvx6WWJ26jXZux8bjKhJniVkpePhRmc+UA/uyObtcrGz7Cd8fH dGgOUcMJIfxc6uVHYNOs34v9lMViQgyCd365GsAvZNczLg6fPBuR/ANHfNRzlo4X B+ZL/aNffXjklJZL1PQgfEoaakhXQ+qqwBuKrma3/dw96EP35fqMr6aYaVqU83II tDpspmnRCbhGRTXYeexQZcOt/m/g5U3XI9jO5pvFrCLAynR6FOCxfqR4RETSKSTL 5MFvuA0GWnicDkHT3L57os5/1lOjgusZApHP4RGhsKWHjpE0TgLgOeAzYFjQ6snV aWcfweRLV0+NPUX+brdmyM/RgJxUfFZMgDr7OLL4/OgK1HSzi5V4jdISl8hy4TeU dSCfkd9hhE0TdSuijMsX =5aMD -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
