On Tue, May 01, 2012 at 10:39:45AM +0100, Simon McVittie wrote: > David: while releasing what was in pkg-games git, I ran into some problems. > The upstream branch in quakespasm.git seems to have been filtered > to remove the SDL binaries, but the pristine-tar metadata seems to result in > the original upstream tarball, with SDL binaries for Windows and Mac OS X. > SDL is under the LGPL, so shipping binaries without corresponding source is > a license violation, and we shouldn't do it. > > It looks as though the solution might be to add "filter-pristine-tar = True" > to gbp.conf and re-run git-import-orig. I'm not sure why that option isn't > the default :-/ > > Stephen: you prepared the last upstream release, and it does seem to have a > correctly-filtered orig tarball. What did you do to get that? Do you have > filter-pristine-tar enabled locally or something?
The rather crummy release you had to fix up (sorry about that!)... My shell history doesn't go that far back, but I seem to remember adding filter-pristine-tar to the git-import-orig command-line, after noticing that the tarball was supposed to be filtered. Adding the option to gbp.conf is definitely better. Re-importing the same tarball probably won't work as-is because git-import-orig won't be able to tag the new upstream; adding +dfsg to the version number would avoid this and indicate that the tarball isn't quite the same as that provided by upstream. Regards, Stephen -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
