On Thu, 9 Sep 2004, Martin Michlmayr wrote:

> Package: debmake
> Version: 3.7.4
> Severity: important
> 
> debmake should really abort when there is a failure.  Otherwise
> packages might "successfully" build but not actually work.

I agree. The problem is that debstd was never designed to fail in case
of error, so it's not as easy as adding "set -e" at the top.

As a partial fix, I've just modified debstd so that it would build itself
if it had "set -e" at the beginning. If you make a diff between version
3.7.8 and 3.7.9, you'll see that most of the changes are like this:

@@ -514,7 +514,7 @@
         fi
       done
     fi
-    X=`find usr/share/man usr/X11*/man -type f 2>/dev/null`
+    X=`find usr/share/man usr/X11*/man -type f 2>/dev/null || true`
     if [ "$X" ]; then
       gzip -9 $X
     else

Now I "just" have to check that adding "set -e" at the top will not
break any of the remaining 110 packages in unstable still using debmake.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to