On Wed, Jan 12, 2005 at 11:29:52AM +0800, pabs wrote: > I reported and supplied the patch for 233161. > I unapplied the patch, and when I put a non-member's address into the > options form on a private list, I get a traceback - duplicated below: [...] > File "/var/lib/mailman/Mailman/OldStyleMemberships.py", line 102, in > getMemberPassword > raise Errors.NotAMemberError, member > NotAMemberError: [EMAIL PROTECTED] > > I've updated the dpatch to fix this in a different (better) way - > attached. This has successfully been tested on a 2.1.4-5 mailman box.
I'm curious on why I can't reproduce this traceback. One possibility might be that I have a fresh install and you might have an older install with membership data from previous versions? That might cause some differences on how the MemberAdaptor works. Sadly Mailman's code base uses such heavy interface magic that I can't verify my suspicion (at least not at this time of the night). Anyway, to me your patch looks like a correct solution to the problem. I tested your patch and I can confirm that it works for me (i.e. solves both the original bug and the membership leakage). -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
