Your message dated Sun, 16 Oct 2022 21:34:20 +0000
with message-id <e1okbh2-00dazw...@fasolo.debian.org>
and subject line Bug#1021893: fixed in device-tree-compiler 1.6.1-4
has caused the Debian Bug report #1021893,
regarding device-tree-compiler: reproducible builds: Embeds build time in in
various binaries
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1021893: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021893
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: device-tree-compiler
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
The build time is embedded in various binaries:
https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/device-tree-compiler.html
/usr/bin/convert-dtsv0
/build/1st/device-tree-compiler-1.6.1/srcpos.c:101
vs.
/build/2/device-tree-compiler-1.6.1/2nd/srcpos.c:101
The attached patch to debian/rules fixes this by passing the default
CFLAGS via EXTRA_CFLAGS, which includes the -ffile-prefix-map compiler
option.
According to my local tests, with this patch applied, device-tree-compiler
should build
reproducibly on tests.reproducible-builds.org!
Thanks for maintaining device-tree-compiler!
live well,
vagrant
From 77ddff89156eb55a550238a490e58023476c8efa Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Sun, 16 Oct 2022 18:02:45 +0000
Subject: [PATCH] debian/rules: Pass default CFLAGS via EXTRA_CFLAGS.
commit 13c4c940e65039052b5be499a848aaa9ffaffaa7 "Enable pylibfdt build
(Closes: #877125)" introduced a regression by removing the default CFLAGS.
This triggered reproducible builds issues with embedded build paths,
because -ffile-prefix-map was no longer getting passed to the
compiler.
The pylibfdt build system ignores CFLAGS, but respects EXTRA_CFLAGS,
so pass all CFLAGS via EXTRA_CFLAGS.
---
debian/rules | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/rules b/debian/rules
index b146728..5aae1d5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -15,7 +15,7 @@ export CC = $(DEB_HOST_GNU_TYPE)-gcc
endif
include /usr/share/dpkg/buildflags.mk
-EXTRA_CFLAGS = -Wno-error
+EXTRA_CFLAGS = $(CFLAGS) -Wno-error
CPPFLAGS += -I libfdt -I .
%:
--
2.37.2
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: device-tree-compiler
Source-Version: 1.6.1-4
Done: Vagrant Cascadian <vagr...@debian.org>
We believe that the bug you reported is fixed in the latest version of
device-tree-compiler, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1021...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Vagrant Cascadian <vagr...@debian.org> (supplier of updated
device-tree-compiler package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 16 Oct 2022 14:10:24 -0700
Source: device-tree-compiler
Architecture: source
Version: 1.6.1-4
Distribution: unstable
Urgency: medium
Maintainer: Héctor Orón Martínez <zu...@debian.org>
Changed-By: Vagrant Cascadian <vagr...@debian.org>
Closes: 1021893
Changes:
device-tree-compiler (1.6.1-4) unstable; urgency=medium
.
* debian/rules: Pass default CFLAGS via EXTRA_CFLAGS. (Closes: #1021893)
Fixes reproducible builds with differing build paths.
* debian/control: Update Standards-Version to 4.6.1.
Checksums-Sha1:
80ae6b7ed13ec5d8801bde0f6f366244b24e4aea 1881 device-tree-compiler_1.6.1-4.dsc
e4b0690f609cfc40d723b9c309f1cf5df3b85f3a 15820
device-tree-compiler_1.6.1-4.debian.tar.xz
d42d0f912c0169ffbddb890ba885f7094ad0d501 10167
device-tree-compiler_1.6.1-4_arm64.buildinfo
Checksums-Sha256:
07ce787cb26d0bce7ec12c745b592bd98c6a5b21cf4fc8a1a657c2d75b14e61d 1881
device-tree-compiler_1.6.1-4.dsc
dfed92335802cfad4903a79f817eaa40b00a8e8795700ba623420e3115db3925 15820
device-tree-compiler_1.6.1-4.debian.tar.xz
8ac4143e861af036d5d40b6f88d50709c63d41fc012f79b45da9ccc4194120fe 10167
device-tree-compiler_1.6.1-4_arm64.buildinfo
Files:
493948e61ea619c7378eec243291bed7 1881 devel optional
device-tree-compiler_1.6.1-4.dsc
d43dcd08c72464cb4c1bee1f16f69c71 15820 devel optional
device-tree-compiler_1.6.1-4.debian.tar.xz
33d369fe9a4f013066eca0e77a6c5568 10167 devel optional
device-tree-compiler_1.6.1-4_arm64.buildinfo
-----BEGIN PGP SIGNATURE-----
iIkEARYKADEWIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY0x1/xMcdmFncmFudEBk
ZWJpYW4ub3JnAAoJENxRj8h/lxaq6H8BANvLk3I+0oAnM5oSKzCSO31pi1epiSSM
PVaIt5gsehYrAP0fTnIVJU0Q/E49dqYSqK68K5WBLx3JJlCH3nc2iLzgAQ==
=aJ6z
-----END PGP SIGNATURE-----
--- End Message ---
